From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12BFA3AEB35 for ; Mon, 15 Jun 2026 05:51:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781502684; cv=none; b=oDP3CAeMarj+QAOuh90EmHBnElqc23poZ6MGeUxTORh9a2xZn2kj3ClVcImHbZ9fhNs6vbfEtLZ+L6YNZlBpVDqFDeQGaWrpTXfhWFvn+zvpeUMbQTK1BTxZRU3kwdhD1pb5fPUoJIdq9THjMGkr0CeLFW3zG056v/Dq7Gv5Nw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781502684; c=relaxed/simple; bh=THM7ahWJk71/LoSX2T6Z8VkcVT1plWm6lCU1L7btHiw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OfNGJP6FYBhypkT77ZJMsPj9/GvkwGbrVqpxxkKW70I0iONhowFG2X8ktuFF3/3xYKFSDC7JHvcnjW13zK/NAnzaqS5SatPZ/6j3CRglvXiCfFbNd9kzwoAfSA76tEsgmaprdFivB8EnT29qre1V2Dic9RbsQhVAeUEZVms2Hmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R9li4ae+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EwW9w/c9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R9li4ae+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EwW9w/c9" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65F1kAF93307890 for ; Mon, 15 Jun 2026 05:51:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 13MV5+oGu9Y4QSitcFuhVSklhqqLnHoOgTil+bf8rdY=; b=R9li4ae+Vk/Iss32 J4asgu/AaZCOoEjhYJJcZCAxfumUZuVwEJGGj5lRbQqIEWGI+lhZO+YPgph48OBn NdvFDGou6r/9QhLO1P8YsYDGh5O7Is1G/ZrrUObW9L4NkUeOsPo0MDazKvblf7rE zELvNJuMIrvx0z4hySPC7KXII04IWtoI+QfxYLXeBM08Wjt3xZhqskyAo+XpkMkR nyNXnhS9fCLVKktQpTmmhnJYBSDxXiH/zvwYWdBFXpE7bP9+bmW7hRg0+RejxzP0 kow7P6sjaFHLBg9qL/0Ys1JwRLJ5oQFC2XsxeLVtHjaVbjMqMOgjy3rvPm0++9qX ofEbTQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eryc6wsjq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 05:51:22 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2c2b64850easo10542845ad.1 for ; Sun, 14 Jun 2026 22:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781502681; x=1782107481; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=13MV5+oGu9Y4QSitcFuhVSklhqqLnHoOgTil+bf8rdY=; b=EwW9w/c9lSrf85qhKSU3PWQOlJa31q3HQVXx3/w3gQkr4cOMXSpSdctALtDy4dnkfD ZpPNa1MFXDq30rDBe07jQWuuDkA7U8htqFGdP2x+wgQQGBuusBKsmJsnSijv8keuT11W UdxQx6yLMUf1XiyIGJZJKx+BS/WbDN3mkJZb4ck4V4hKEc0FGnlmAtetQ+U52CO4SbJC ZyKWzOfYj7PPx/rY7qp07SMliJvhOrnEBE/p62v6QNCetAiXlP1LK6uJ3ppIZkXlh647 3jih771OyTdjUI/lHiK/Jv/Wwqm8xMCo5mfJ0TZgNFO1hg4uAzJVPmA65zbuBTFXwsn5 twig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781502681; x=1782107481; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=13MV5+oGu9Y4QSitcFuhVSklhqqLnHoOgTil+bf8rdY=; b=j47oTT/8gsRK8x/W4vNOWtZnleVOZojflCIZN1nzc8tMGbLV+bZ1w9K5/fZf3JaTf8 O9DuXZpYPl/1BrUkm60xkiVM9ojQlGyzSU/TonWihYcX/PIl/om+S6oFDzAxOM2qUcMR rUzRZdnpTGX99Jg7f2YUQQ1OLDeBhl5PkAJ6/vqTlfxxyJ7qg/HxYOnYDJBj23S2lcUS GEC0REBkvoUbISKChmY3cG5Qai8UgKnDGz81tDqF+IWLPwzI7gsO7epLKuU84tBTNM+S gGYJa8T3JAKgU90uHG8MtDccYAectsBtD8xgHaOZ+fuguqMAwHSXPJrT5a/eVn830ckA y3Cg== X-Forwarded-Encrypted: i=1; AFNElJ88WngsLrNQoU9oi6pEq/vTZsfFRstI4Uh7GRmfNpmRsvl24JmWvenC5lBxpWS1MEzikod+cklMlLWLrRQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzRjhnujut/dWE6CW0nIujEk3OReYT9DGVePj6O5ULdt0b83/c2 Q6fEPaxEbR+8x4zZReg2pH0JeZ9p/+4TKRlSVUFN/rP97zh5vAHsMAlxjv6FFJIm13wwZHqmbic qvdQAZTnDjeSeCJ2UWMsl0U8h5Y6sfca+LIeES+ksoMRvBz6oPLBLFmlPi6lMRHuCQcc= X-Gm-Gg: Acq92OH6RzbMvsjAY83qHL2d7YcvAf4Z3yjcB53FeP9F49eMsYyEAOTHuWcCcM7bFkH VE+o6QcMr4Xk+Xo3OX4Mo1ymKt+9Z5p6IhBBelyeTkbZs1nuPw7hMIlfL45iQcsLakrw+qZStzC CSqPmBxgVGB/8GbwCNEnn7Zx3HqPa8vkEeM7ZJTKuKyEoDQf18au04AAcQFDgS9yRfzvTWddnFM k+Sh0ZXO/DnU/D7FeDWEu77MxnZHYaJfD+QfOg4J8slE6B5OCpsK67jRKkOpjH/twQYVZ/0gmki x7C53wixLM0NOStSj01tFnqmbt3wuoo9MShCfHADAjEWdSIQIl6M+WLhRnvVG5l9MckoByu/5kl 5oyN1z1yFP5A4BHWTe8V1Q+rJq0qYp5Xr9Pl3NbAAAxN0LfjGKxh9 X-Received: by 2002:a17:902:ebc7:b0:2bd:5ab:af95 with SMTP id d9443c01a7336-2c664082585mr114141675ad.0.1781502681075; Sun, 14 Jun 2026 22:51:21 -0700 (PDT) X-Received: by 2002:a17:902:ebc7:b0:2bd:5ab:af95 with SMTP id d9443c01a7336-2c664082585mr114141265ad.0.1781502680609; Sun, 14 Jun 2026 22:51:20 -0700 (PDT) Received: from [10.92.170.188] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c432c8ce89sm89192275ad.57.2026.06.14.22.51.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jun 2026 22:51:20 -0700 (PDT) Message-ID: <1403607d-a277-4300-abe4-56648b3c2a1f@oss.qualcomm.com> Date: Mon, 15 Jun 2026 11:21:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] phy: qcom-qmp-ufs: Add UFS PHY support on Hawi To: Vinod Koul Cc: neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mani@kernel.org, alim.akhtar@samsung.com, bvanassche@acm.org, andersson@kernel.org, dmitry.baryshkov@oss.qualcomm.com, abel.vesa@oss.qualcomm.com, luca.weiss@fairphone.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, nitin.rawat@oss.qualcomm.com References: <20260526090956.2340262-1-palash.kambar@oss.qualcomm.com> <20260526090956.2340262-4-palash.kambar@oss.qualcomm.com> Content-Language: en-US From: Palash Kambar In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDA1OCBTYWx0ZWRfX9DVLajXg9aME 1zpKwZAgZmvnEgTLttz0fL5KCRrmL/uzXPsZWveXWNE5E1AK3OHsvp80KrUwiIFgi4sXOsgOecG Xnk9oJqJaN3NF8ALMEkgD8FUGWhks50= X-Authority-Analysis: v=2.4 cv=Oop/DS/t c=1 sm=1 tr=0 ts=6a2f92da cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=YxLorS6-WnmH7tsLkT0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: z8YmcY0DCeJC-oct3tZACqn2LCbgPAIi X-Proofpoint-ORIG-GUID: z8YmcY0DCeJC-oct3tZACqn2LCbgPAIi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDA1OCBTYWx0ZWRfX+I8KPjJH2cDP AbDB+s8RSVLqE8O3KJY8qWz08NVVV6qPaWp2ShAd6m0YzK5CBUs5HPsNyOI+meMU8ReyhgIF2Ya 8pZNKmQDhaW4ErJAJ81yFMVgxGdR+pxxUV41VwjvMAy/86fEsa7vdPwLSZ8yZvevPo4WitCObEy wW68nt/pA2CSOubPjCUjbBCfAXI3fokxzBhOXWL9CnEwJ/NgpWOF2XnKGRo5SleEjC++aux467m DasftddfC90CglvQs5bJJL7mjLB59VIOs1+AwNUKtAcqK7eNCnH49//eerj9c3+cie3wCxzhiZt RQWn1zDG/W4kVmXzZWJ6TjJ2lXRXpmM0rIwJfrKz1gc4DokarRYCiG1aqhkzobe/4upgnrs4Kbp kUt21Z5j3vbkBLQAU0a34IKSTtNMCyL0v8uiLzgT0f8lPkeDOdBfMMFm7oQpvPdZMoAKywKVxd2 jdUPUiwAblPtyQqNZeQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_01,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150058 On 6/11/2026 8:59 PM, Vinod Koul wrote: > On 26-05-26, 14:39, palash.kambar@oss.qualcomm.com wrote: >> From: Palash Kambar >> >> Add the init sequence tables and config for the UFS QMP phy found in >> the Hawi SoC. > > This fails to build for me on phy/next > > In file included from drivers/phy/qualcomm/phy-qcom-qmp-ufs.c:24: > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c:1878:26: error: ‘QSERDES_V8_COM_PLL_IVCO_MODE1’ undeclared here (not in a function); did you mean ‘QSERDES_V6_COM_PLL_IVCO_MODE1’? > 1878 | QMP_PHY_INIT_CFG(QSERDES_V8_COM_PLL_IVCO_MODE1, 0x1f), > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/phy/qualcomm/phy-qcom-qmp-common.h:22:27: note: in definition of macro ‘QMP_PHY_INIT_CFG’ > 22 | .offset = o, \ > | ^ > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c:1879:26: error: ‘QSERDES_V8_COM_CMN_IETRIM’ undeclared here (not in a function); did you mean ‘QSERDES_V6_COM_CMN_IETRIM’? > 1879 | QMP_PHY_INIT_CFG(QSERDES_V8_COM_CMN_IETRIM, 0x07), > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/phy/qualcomm/phy-qcom-qmp-common.h:22:27: note: in definition of macro ‘QMP_PHY_INIT_CFG’ > 22 | .offset = o, \ > > And so on. Looks like QSERDES_V8_COM_PLL_IVCO_MODE1 etc are not define. > Please rebase test and send again > Hi Vinod, Sure, will rebase and check. Thanks.