mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Cheng-Wei Lee <lee.rhapsody@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>,
	Avinash Kumar <avi.kp.137@gmail.com>,
	Peter Senna Tschudin <peter.senna@gmail.com>,
	devel <devel@driverdev.osuosl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function
Date: Wed, 25 Jun 2014 17:09:22 -0700	[thread overview]
Message-ID: <1403741362.28663.12.camel@joe-AO725> (raw)
In-Reply-To: <CAJKoSVRLvPe+5tae=buV3j12L612tdaYAWMT303GO71NF-w27g@mail.gmail.com>

On Wed, 2014-06-25 at 23:35 +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: Missing a blank line after declarations

Still has a mismatch between subject and code

> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
[]
> @@ -3533,7 +3533,7 @@ static void hfa384x_usbin_rx(wlandevice_t
> *wlandev, struct sk_buff *skb)
>  	}
> 
>  done:
> -	return;
> +	pr_debug("hfa384x_usbin_rx: done\n");

I suggest you just leave the return,

Any checkpatch suggestion this was needed was a false
positive that should be resolved by this patch:

http://article.gmane.org/gmane.linux.kernel/1728891



  reply	other threads:[~2014-06-26  0:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 15:35 Cheng-Wei Lee
2014-06-26  0:09 ` Joe Perches [this message]
2014-06-26  1:51   ` Cheng-Wei Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403741362.28663.12.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=avi.kp.137@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.rhapsody@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.senna@gmail.com \
    --cc=shehabaldin.sherif@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®