From: Joe Perches <joe@perches.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Andy Whitcroft <apw@canonical.com>,
gregkh@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/checkpatch.pl: Only emit LONG_LINE for --strict
Date: Wed, 25 Jun 2014 22:29:30 -0700 [thread overview]
Message-ID: <1403760570.7977.28.camel@joe-AO725> (raw)
In-Reply-To: <20140626050824.GB1645@thin>
On Wed, 2014-06-25 at 22:08 -0700, Josh Triplett wrote:
> Now, arguably the four leading tabs on those lines suggest the need for
> some code refactoring; personally, I'd suggest changing DEEP_INDENTATION
> to flag 4+ tabs rather than 6+ tabs as it currently does.
There are _way too many_ 4+ tab indents for that to
be sensible.
> "trigraphs"? Do you mean ternaries? Yeah,
Yup, those.
> Yeah, that one makes sense: if you have a comment to the right of a long
> line, and the comment is what's making it long, it's easy enough to move
> the comment before the line.
next prev parent reply other threads:[~2014-06-26 5:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 15:46 Josh Triplett
2014-06-26 0:05 ` Joe Perches
2014-06-26 2:24 ` Josh Triplett
2014-06-26 2:33 ` Joe Perches
2014-06-26 3:44 ` Josh Triplett
2014-06-26 4:16 ` Joe Perches
2014-06-26 5:08 ` Josh Triplett
2014-06-26 5:29 ` Joe Perches [this message]
2014-06-26 5:49 ` Josh Triplett
2014-06-26 3:59 ` Greg KH
2014-06-26 4:43 ` Josh Triplett
2014-06-26 6:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403760570.7977.28.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=gregkh@linux-foundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®