mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>, Keerthy J <j-keerthy@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>, <linux-kernel@vger.kernel.org>,
	<linux-omap@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	Nishanth Menon <nm@ti.com>
Subject: [PATCH V2 1/6] regulator: palmas: Squelch sparse warnings
Date: Mon, 30 Jun 2014 10:57:34 -0500	[thread overview]
Message-ID: <1404143859-8160-2-git-send-email-nm@ti.com> (raw)
In-Reply-To: <1404143859-8160-1-git-send-email-nm@ti.com>

convert to static variables to squelch the following sparse warnings:
drivers/regulator/palmas-regulator.c:325:36: warning: symbol 'palma_sleep_req_info' was not declared. Should it be static?
drivers/regulator/palmas-regulator.c:1414:32: warning: symbol 'palmas_ddata' was not declared. Should it be static?
drivers/regulator/palmas-regulator.c:1427:32: warning: symbol 'tps65917_ddata' was not declared. Should it be static?

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 drivers/regulator/palmas-regulator.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 7c8b441..91f60fa 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -322,7 +322,7 @@ static struct regs_info tps65917_regs_info[] = {
 		.bit_pos = _pos,			\
 	}
 
-struct palmas_sleep_requestor_info palma_sleep_req_info[] = {
+static struct palmas_sleep_requestor_info palma_sleep_req_info[] = {
 	EXTERNAL_REQUESTOR(REGEN1, 0, 0),
 	EXTERNAL_REQUESTOR(REGEN2, 0, 1),
 	EXTERNAL_REQUESTOR(SYSEN1, 0, 2),
@@ -1408,7 +1408,7 @@ static struct of_regulator_match tps65917_matches[] = {
 	{ .name = "sysen2", },
 };
 
-struct palmas_pmic_driver_data palmas_ddata = {
+static struct palmas_pmic_driver_data palmas_ddata = {
 	.smps_start = PALMAS_REG_SMPS12,
 	.smps_end = PALMAS_REG_SMPS10_OUT1,
 	.ldo_begin = PALMAS_REG_LDO1,
@@ -1421,7 +1421,7 @@ struct palmas_pmic_driver_data palmas_ddata = {
 	.ldo_register = palmas_ldo_registration,
 };
 
-struct palmas_pmic_driver_data tps65917_ddata = {
+static struct palmas_pmic_driver_data tps65917_ddata = {
 	.smps_start = TPS65917_REG_SMPS1,
 	.smps_end = TPS65917_REG_SMPS5,
 	.ldo_begin = TPS65917_REG_LDO1,
-- 
1.7.9.5


  reply	other threads:[~2014-06-30 15:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 15:57 [PATCH V2 0/6] regulator: palmas: cleanup and fixes Nishanth Menon
2014-06-30 15:57 ` Nishanth Menon [this message]
2014-06-30 15:57 ` [PATCH V2 2/6] regulator: palmas: Rename reg_info to palmas_reg_info Nishanth Menon
2014-07-01  7:41   ` Lee Jones
2014-06-30 15:57 ` [PATCH V2 3/6] regulator: palmas: Simplify code by using pointer " Nishanth Menon
2014-06-30 15:57 ` [PATCH V2 4/6] regulator: palmas: Rename palmas_regs_info to palmas_generic_regs_info Nishanth Menon
2014-06-30 15:57 ` [PATCH V2 5/6] regulator: palmas: Simplify code by not indexing regulator_desc unnecessarily Nishanth Menon
2014-06-30 15:57 ` [PATCH V2 6/6] regulator: palmas: Fix SMPS enable/disable/is_enable for tps65917 Nishanth Menon
2014-06-30 20:22 ` [PATCH V2 0/6] regulator: palmas: cleanup and fixes Stephen Warren
2014-07-01  5:14   ` Keerthy
2014-07-02  5:15 ` Keerthy
2014-07-03 14:26 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404143859-8160-2-git-send-email-nm@ti.com \
    --to=nm@ti.com \
    --cc=broonie@kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome