From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vinod.koul@intel.com>, <dan.j.williams@intel.com>,
<lars@metafoo.de>, <tiwai@suse.de>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>, <joelf@ti.com>,
<nsekhar@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<dmaengine@vger.kernel.org>
Subject: [PATCH v2 4/5] ALSA: pcm_dmaengine: Correct support for 24bits physical sample widths
Date: Wed, 2 Jul 2014 16:29:22 +0300 [thread overview]
Message-ID: <1404307763-30557-5-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1404307763-30557-1-git-send-email-peter.ujfalusi@ti.com>
In case of _3LE/_3BE formats the samples are stored in 3 consecutive bytes
without padding it to 4 bytes. This means that the DMA needs to be able to
support 3 bytes word length in order to read/write the samples from memory
correctly. Originally the code treated 24 bits physical length samples as
they were 32 bits which leads to corruption when playing or recording audio.
The hw.formats field has already been prepared to exclude formats not
supported by the DMA engine in use, which means that only on platforms where
3 bytes is supported by the DMA will be able to use this format.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/core/pcm_dmaengine.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c
index d5611ec80381..6542c4083594 100644
--- a/sound/core/pcm_dmaengine.c
+++ b/sound/core/pcm_dmaengine.c
@@ -72,6 +72,8 @@ int snd_hwparams_to_dma_slave_config(const struct snd_pcm_substream *substream,
buswidth = DMA_SLAVE_BUSWIDTH_1_BYTE;
else if (bits == 16)
buswidth = DMA_SLAVE_BUSWIDTH_2_BYTES;
+ else if (bits == 24)
+ buswidth = DMA_SLAVE_BUSWIDTH_3_BYTES;
else if (bits <= 32)
buswidth = DMA_SLAVE_BUSWIDTH_4_BYTES;
else
--
2.0.0
next prev parent reply other threads:[~2014-07-02 13:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 13:29 [PATCH v2 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support Peter Ujfalusi
2014-07-02 13:29 ` [PATCH v2 1/5] dma: Support for 3 bytes word size Peter Ujfalusi
2014-07-02 13:29 ` [PATCH v2 2/5] ALSA: pcm_dmaengine: Use the available wrapper to get physical width Peter Ujfalusi
2014-07-02 13:29 ` [PATCH v2 3/5] ASoC: generic-dmaengine-pcm: Prepare formats mask for valid physical sample sizes Peter Ujfalusi
2014-07-02 13:47 ` Takashi Iwai
2014-07-02 14:10 ` [alsa-devel] " Lars-Peter Clausen
2014-07-02 14:12 ` Takashi Iwai
2014-07-02 14:13 ` Lars-Peter Clausen
2014-07-02 14:24 ` Takashi Iwai
2014-07-02 13:29 ` Peter Ujfalusi [this message]
2014-07-02 13:29 ` [PATCH v2 5/5] dma: edma: Declare DMA_SLAVE_BUSWIDTH_3_BYTES as supported buswidth Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404307763-30557-5-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=joelf@ti.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®