From: Kishon Vijay Abraham I <kishon@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <kishon@ti.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/8] usb: phy: omap-usb2: fix devm_ioremap_resource error detection code
Date: Mon, 7 Jul 2014 12:18:19 +0530 [thread overview]
Message-ID: <1404715705-5041-3-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1404715705-5041-1-git-send-email-kishon@ti.com>
From: Himangi Saraogi <himangi774@gmail.com>
devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure.
A simplified version of the semantic match that finds this problem is as
follows:
// <smpl>
@@
expression e,e1;
statement S;
@@
*e = devm_ioremap_resource(...);
if (!e1) S
// </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/phy-omap-usb2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c
index 7007c11..2063d54 100644
--- a/drivers/phy/phy-omap-usb2.c
+++ b/drivers/phy/phy-omap-usb2.c
@@ -233,8 +233,8 @@ static int omap_usb2_probe(struct platform_device *pdev)
if (phy_data->flags & OMAP_USB2_CALIBRATE_FALSE_DISCONNECT) {
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
phy->phy_base = devm_ioremap_resource(&pdev->dev, res);
- if (!phy->phy_base)
- return -ENOMEM;
+ if (IS_ERR(phy->phy_base))
+ return PTR_ERR(phy->phy_base);
phy->flags |= OMAP_USB2_CALIBRATE_FALSE_DISCONNECT;
}
--
1.7.9.5
next prev parent reply other threads:[~2014-07-07 6:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 6:48 [GIT PULL 0/8] phy: fixes for 3.16 -rc cycle Kishon Vijay Abraham I
2014-07-07 6:48 ` [PATCH 1/8] phy: sun4i: depend on RESET_CONTROLLER Kishon Vijay Abraham I
2014-07-07 6:48 ` Kishon Vijay Abraham I [this message]
2014-07-07 6:48 ` [PATCH 3/8] phy: phy-samsung-usb2: Change phy power on/power off sequence Kishon Vijay Abraham I
2014-07-08 1:44 ` Greg KH
2014-07-08 6:12 ` Kishon Vijay Abraham I
2014-07-09 21:36 ` Greg KH
2014-07-10 5:48 ` Kishon Vijay Abraham I
2014-07-07 6:48 ` [PATCH 4/8] drivers: phy: phy-samsung-usb2.c: Add missing MODULE_DEVICE_TABLE Kishon Vijay Abraham I
2014-07-07 6:48 ` [PATCH 5/8] phy: core: Fix error path in phy_create() Kishon Vijay Abraham I
2014-07-08 1:45 ` Greg KH
2014-07-08 6:14 ` Kishon Vijay Abraham I
2014-07-07 6:48 ` [PATCH 6/8] phy: core: Support regulator supply for PHY power Kishon Vijay Abraham I
2014-07-08 1:45 ` Greg KH
2014-07-08 6:18 ` Kishon Vijay Abraham I
2014-07-07 6:48 ` [PATCH 7/8] phy: core: Add phy-supply to DT binding documentation Kishon Vijay Abraham I
2014-07-07 6:48 ` [PATCH 8/8] phy: omap-usb2: Balance pm_runtime_enable() on probe failure and remove Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404715705-5041-3-git-send-email-kishon@ti.com \
--to=kishon@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome