From: Guillaume Clement <gclement@baobob.org>
To: Julian Andres Klode <jak@jak-linux.org>,
Marc Dietrich <marvin24@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: ac100@lists.launchpad.net, linux-tegra@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Guillaume Clement <gclement@baobob.org>
Subject: [PATCH 2/5] staging:nvec: Remove unnessary out of memory message.
Date: Tue, 8 Jul 2014 00:31:34 +0200 [thread overview]
Message-ID: <1404772297-6549-3-git-send-email-gclement@baobob.org> (raw)
In-Reply-To: <1404772297-6549-1-git-send-email-gclement@baobob.org>
Logging messages that show some type of "out of memory" error
are generally unnecessary as there is a generic message and
a stack dump done by the memory subsystem.
Signed-off-by: Guillaume Clément <gclement@baobob.org>
---
drivers/staging/nvec/nvec.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 8a3dd47..d325048 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -806,10 +806,9 @@ static int tegra_nvec_probe(struct platform_device *pdev)
}
nvec = devm_kzalloc(&pdev->dev, sizeof(struct nvec_chip), GFP_KERNEL);
- if (nvec == NULL) {
- dev_err(&pdev->dev, "failed to reserve memory\n");
+ if (nvec == NULL)
return -ENOMEM;
- }
+
platform_set_drvdata(pdev, nvec);
nvec->dev = &pdev->dev;
--
1.8.5.5
next prev parent reply other threads:[~2014-07-07 22:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 22:31 [PATCH] staging:nvec: Fix several coding style warnings Guillaume Clement
2014-07-07 22:31 ` [PATCH 1/5] staging:nvec: Fix "unnecessary else" coding style warning Guillaume Clement
2014-07-07 22:31 ` Guillaume Clement [this message]
2014-07-07 22:31 ` [PATCH 3/5] staging:nvec: Add missing blank line after declarations Guillaume Clement
2014-07-07 22:31 ` [PATCH 4/5] " Guillaume Clement
2014-07-07 22:31 ` [PATCH 5/5] " Guillaume Clement
2014-07-08 8:26 ` Dan Carpenter
2014-07-08 10:14 ` [PATCH] staging:nvec: Fix several coding style warnings Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404772297-6549-3-git-send-email-gclement@baobob.org \
--to=gclement@baobob.org \
--cc=ac100@lists.launchpad.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jak@jak-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®