mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tang Chen <tangchen@cn.fujitsu.com>
To: <gleb@kernel.org>, <mtosatti@redhat.com>, <nadav.amit@gmail.com>
Cc: <kvm@vger.kernel.org>, <laijs@cn.fujitsu.com>,
	<isimatu.yasuaki@jp.fujitsu.com>, <guz.fnst@cn.fujitsu.com>,
	<linux-kernel@vger.kernel.org>, <tangchen@cn.fujitsu.com>
Subject: [PATCH v2 3/5] kvm, mem-hotplug: Do not pin ept identity pagetable in memory.
Date: Tue, 8 Jul 2014 21:01:30 +0800	[thread overview]
Message-ID: <1404824492-30095-4-git-send-email-tangchen@cn.fujitsu.com> (raw)
In-Reply-To: <1404824492-30095-1-git-send-email-tangchen@cn.fujitsu.com>

ept identity page is pinned in memory. As a result, it cannot be migrated/hot-removed.

Actually, this page is not necessary to be pinned. When it is migrated,
mmu_notifier_invalidate_page() in try_to_unmap_one() will invalidate the ept
entry so that the guest won't be able to access the page. And in the next ept
violation, the new page will be found by ept violation handler.

This patch just unpin the ept identity page because it is not necessary.

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
 arch/x86/kvm/vmx.c | 3 ++-
 arch/x86/kvm/x86.c | 2 --
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 0e1117c..0918635e 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -4018,7 +4018,8 @@ static int alloc_identity_pagetable(struct kvm *kvm)
 	if (r)
 		goto out;
 
-	page = gfn_to_page(kvm, kvm->arch.ept_identity_map_addr >> PAGE_SHIFT);
+	page = gfn_to_page_no_pin(kvm,
+				kvm->arch.ept_identity_map_addr >> PAGE_SHIFT);
 	if (is_error_page(page)) {
 		r = -EFAULT;
 		goto out;
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index f32a025..ffbe557 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -7177,8 +7177,6 @@ void kvm_arch_destroy_vm(struct kvm *kvm)
 	kvm_free_vcpus(kvm);
 	if (kvm->arch.apic_access_page)
 		put_page(kvm->arch.apic_access_page);
-	if (kvm->arch.ept_identity_pagetable)
-		put_page(kvm->arch.ept_identity_pagetable);
 	kfree(rcu_dereference_check(kvm->arch.apic_map, 1));
 }
 
-- 
1.8.3.1


  parent reply	other threads:[~2014-07-08 13:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 13:01 [PATCH v2 0/5] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-07-08 13:01 ` [PATCH v2 1/5] kvm: Add gfn_to_page_no_pin() to translate gfn to page without pinning Tang Chen
2014-07-08 13:01 ` [PATCH v2 2/5] kvm: Use APIC_DEFAULT_PHYS_BASE macro as the apic access page address Tang Chen
2014-07-08 13:01 ` Tang Chen [this message]
2014-07-08 13:01 ` [PATCH v2 4/5] kvm: Remove ept_identity_pagetable from struct kvm_arch Tang Chen
2014-07-09  2:06   ` Tang Chen
2014-07-09  2:08   ` [RESEND PATCH " Tang Chen
2014-07-12  7:44     ` Gleb Natapov
2014-07-14  9:17       ` Tang Chen
2014-07-14 14:27         ` Gleb Natapov
2014-07-15 10:39           ` Tang Chen
2014-07-08 13:01 ` [PATCH v2 5/5] kvm, mem-hotplug: Do not pin apic access page in memory Tang Chen
2014-07-12  8:04   ` Gleb Natapov
2014-07-14  7:57     ` Tang Chen
2014-07-14 14:58       ` Gleb Natapov
2014-07-15 11:52         ` Jan Kiszka
2014-07-15 12:09           ` Gleb Natapov
2014-07-15 12:28             ` Tang Chen
2014-07-15 12:40               ` Gleb Natapov
2014-07-15 12:54                 ` Tang Chen
2014-07-15 14:40                   ` Gleb Natapov
2014-07-17  9:22                     ` Tang Chen
2014-07-15 13:10                 ` Jan Kiszka
2014-07-15 14:04                   ` Gleb Natapov
2014-07-17 13:34                 ` Tang Chen
2014-07-17 13:57                   ` Gleb Natapov
2014-07-18  9:05                     ` Tang Chen
2014-07-18 11:21                       ` Gleb Natapov
2014-07-15 12:11           ` Tang Chen
2014-07-09  1:20 ` [PATCH v2 0/5] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-07-11  6:23 ` Tang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404824492-30095-4-git-send-email-tangchen@cn.fujitsu.com \
    --to=tangchen@cn.fujitsu.com \
    --cc=gleb@kernel.org \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=nadav.amit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®