From: Vincent Heuken <me@vincentheuken.com>
To: willy@meta-x.org, gregkh@linuxfoundation.org,
armand.bastien@laposte.net, domdevlin@free.fr,
monamagarwal123@gmail.com, julia.lawall@lip6.fr, arnd@arndb.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Vincent Heuken <me@vincentheuken.com>
Subject: [PATCH] Staging: panel: fixed frivilous else statement warning
Date: Thu, 10 Jul 2014 03:34:28 -0700 [thread overview]
Message-ID: <1404988468-8032-1-git-send-email-me@vincentheuken.com> (raw)
Fixed one instance of the following checkpatch.pl warning in
panel.c:
WARNING: else is not generally useful after a break or return
Signed-off-by: Vincent Heuken <me@vincentheuken.com>
---
drivers/staging/panel/panel.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 4e92293..6d1a320 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1800,11 +1800,12 @@ static inline int input_state_high(struct logical_input *input)
input->high_timer++;
}
return 1;
- } else {
- /* else signal falling down. Let's fall through. */
- input->state = INPUT_ST_FALLING;
- input->fall_timer = 0;
}
+
+ /* else signal falling down. Let's fall through. */
+ input->state = INPUT_ST_FALLING;
+ input->fall_timer = 0;
+
return 0;
}
--
2.0.1
next reply other threads:[~2014-07-10 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 10:34 Vincent Heuken [this message]
2014-07-18 9:35 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404988468-8032-1-git-send-email-me@vincentheuken.com \
--to=me@vincentheuken.com \
--cc=armand.bastien@laposte.net \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=domdevlin@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®