From: Addy Ke <addy.ke@rock-chips.com>
To: broonie@kernel.org, heiko@sntech.de, grant.likely@linaro.org,
robh+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
jogo@openwrt.org, olof@lixom.net, hj@rock-chips.com,
kever.yang@rock-chips.com, xjq@rock-chips.com,
huangtao@rock-chips.com, zyw@rock-chips.com, yzq@rock-chips.com,
zhenfu.fang@rock-chips.com, cf@rock-chips.com,
zhangqing@rock-chips.com, hl@rock-chips.com,
wei.luo@rock-chips.com, Addy Ke <addy.ke@rockchip.com>
Subject: [PATCH 3/4] spi/rockchip: master->mode_bits: remove SPI_CS_HIGH bit
Date: Fri, 11 Jul 2014 10:08:51 +0800 [thread overview]
Message-ID: <1405044531-6963-1-git-send-email-addy.ke@rock-chips.com> (raw)
In-Reply-To: <1405044389-6800-1-git-send-email-addy.ke@rock-chips.com>
From: Addy Ke <addy.ke@rockchip.com>
Suggested-by: Jonas Gorski <jogo@openwrt.org>
Signed-off-by: Addy Ke <addy.ke@rockchip.com>
---
drivers/spi/spi-rockchip.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 09c690c..a8866c9 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -295,11 +295,6 @@ static int rockchip_spi_prepare_message(struct spi_master *master,
struct rockchip_spi *rs = spi_master_get_devdata(master);
struct spi_device *spi = msg->spi;
- if (spi->mode & SPI_CS_HIGH) {
- dev_err(rs->dev, "spi_cs_hign: not support\n");
- return -EINVAL;
- }
-
rs->mode = spi->mode;
return 0;
@@ -657,7 +652,7 @@ static int rockchip_spi_probe(struct platform_device *pdev)
master->auto_runtime_pm = true;
master->bus_num = pdev->id;
- master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LOOP;
+ master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LOOP;
master->num_chipselect = 2;
master->dev.of_node = pdev->dev.of_node;
master->bits_per_word_mask = SPI_BPW_MASK(16) | SPI_BPW_MASK(8);
--
1.8.3.2
next prev parent reply other threads:[~2014-07-11 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 2:06 [PATCH 0/4] patches for rockchip spi driver Addy Ke
2014-07-11 2:07 ` [PATCH 1/4] spi/rockchip: cleanup some coding issues and uncessary output Addy Ke
2014-07-11 2:08 ` [PATCH 2/4] spi/rockchip: call wait_for_idle() for the transfer to complete Addy Ke
2014-07-11 2:08 ` Addy Ke [this message]
2014-07-11 2:09 ` [PATCH 4/4] spi/rockchip: add compatible strings for RK3188 and RK3288 Addy Ke
2014-07-11 13:00 ` [PATCH 0/4] patches for rockchip spi driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405044531-6963-1-git-send-email-addy.ke@rock-chips.com \
--to=addy.ke@rock-chips.com \
--cc=addy.ke@rockchip.com \
--cc=broonie@kernel.org \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=hj@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=jogo@openwrt.org \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=wei.luo@rock-chips.com \
--cc=xjq@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zhenfu.fang@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®