mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gavin Guo <gavin.guo@canonical.com>
To: sarah.a.sharp@linux.intel.com, mathias.nyman@intel.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: yk@canonical.com, anthony.wong@canonical.com, gerald.yang@canonical.com
Subject: [PATCH 0/1] Fixes to the USB 3.0 detection as 2.0 on AMD platform
Date: Fri, 11 Jul 2014 14:22:35 +0800	[thread overview]
Message-ID: <1405059756-11983-1-git-send-email-gavin.guo@canonical.com> (raw)

Hi Sarah and Mathias,

As the discussion in http://comments.gmane.org/gmane.linux.usb.general/107011, 
I found that [AMD] FCH USB XHCI Controller [1022:7814] the USB 3.0 disk 
can't work in SuperSpeed after several times of hotplug. After doing some 
experiments and bisection, I found the bug is caused by 
41e7e056cdc662f704fa9262e5c6e213b4ab45dd (USB: Allow USB 3.0 ports to be 
disabled.). And the bug can be fixed by not executing the 
hub_usb3_port_disable() function. I also found that the port status is 
already in RxDetect before setting the port to Disabled in 
hub_usb3_port_disable() function. So, there are 2 ways to fix the bug:

1) Check if the Vendor/Device id is [1022:7814] at the beginning of 
hub_usb3_port_disable() function. If yes, return without executing the 
remaining code.

2) Check if the port status is already in RxDetect, if yes, return without 
executing the remaining code.

The second method seems more reasonable, so the patch is the implementation
of the second one. But it will affect more platforms and I don't know if 
there'll be any negative result. Otherwise, if the first one is correct, 
I can reimplement a new one.

I'm appreciated if you can give me some advice, or if there is any thing I missed.

Thanks,
Gavin

Gavin Guo (1):
  usb: Check if port status is equal to RxDetect

 drivers/usb/core/hub.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

-- 
2.0.0


             reply	other threads:[~2014-07-11  6:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  6:22 Gavin Guo [this message]
2014-07-11  6:22 ` [PATCH 1/1] usb: Check if port status is equal to RxDetect Gavin Guo
2014-07-11 23:33   ` Gavin Guo
2014-07-15 14:24   ` Alan Stern
2014-07-11 23:32 ` [PATCH 0/1] Fixes to the USB 3.0 detection as 2.0 on AMD platform Gavin Guo
2014-07-12  0:04   ` Greg KH
2014-07-12  0:28     ` Gavin Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405059756-11983-1-git-send-email-gavin.guo@canonical.com \
    --to=gavin.guo@canonical.com \
    --cc=anthony.wong@canonical.com \
    --cc=gerald.yang@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=yk@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®