mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jianqun <xjq@rock-chips.com>
To: heiko@sntech.de, lgirdwood@gmail.com, broonie@kernel.org,
	perex@perex.cz, tiwai@suse.de, grant.likely@linaro.org,
	robh+dt@kernel.org, zhangqing@rock-chips.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	devicetree@vger.kernel.org, hj@rock-chips.com,
	kever.yang@rock-chips.com, huangtao@rock-chips.com,
	zyw@rock-chips.com, yzq@rock-chips.com,
	zhenfu.fang@rock-chips.com, cf@rock-chips.com,
	kfx@rock-chips.com, Jianqun Xu <xjq@rock-chips.com>
Subject: [PATCH 0/2] add rockchip i2s driver
Date: Fri, 11 Jul 2014 17:54:47 +0800	[thread overview]
Message-ID: <1405072489-20802-1-git-send-email-xjq@rock-chips.com> (raw)

From: Jianqun Xu <xjq@rock-chips.com>

This patch is to add driver for I2S controller in RK3xxx SoCs.

The only one change in this patch against which has been reviewed before is to 
fix randconfig build error with next-20140710 by add "#include <linux/module.h>".

Jianqun Xu (2):
  ASoC: dt-bindings: add rockchip i2s bindings

changes since v2:
 - change the description of dma-names, adviced by Mark
 - change the description of interrupts, adviced by Mark
 - list clock-names to be easy to read, adviced by Mark
 - modify compatible for rk3288 example, adviced by Mark and Heiko

 changes since v1:
 - modify the description of clock-names property, adviced by Mark Rutland.
 - modify the example to fit for rk3288.


  ASoC: add driver for Rockchip RK3xxx I2S controller

changes since v3:
 - fix randconfig build error with next-20140710 by add "#include <linux/module.h>"
   tested with config given by robot test.

changes since v2:
 - replace 4 with DMA_SLAVE_BUSWIDTH_4_BYTES
 - modify supported rate to SNDRV_PCM_RATE_8000_192000
 - rename head file to "rockchi_i2s.h"

changes since v1:
 - proper indentation for function arguments, adviced by Varka Bhadram
 - replace sizeof(struct rk_i2s_dev) with sizeof(*i2s), adviced by Mark Rutland
 - not to include head files which are unused actually in driver, adviced by Mark Brown
 - modify i2s_tx_status/i2s_rx_status to more meaningful with tx_start/rx_start, adviced by Mark Brown
 - use regmap_update_bits to reduce the amount of time spent locked, adviced by Mark Brown
 - add warning for possible error while waiting for the hardware to be ready, adviced by Mark Brown
 - error checking for clk_set_rate, adviced by Mark Brown
 - error checking for i2s_runtime_resume, adviced by Mark Brown
 - remove set_clkdiv operation, clock setting will do it, adviced by Mark Brown
 - no need SND_SOC for SND_SOC_ROCKCHIP, also allow the driver to be select when
   COMPILE_TEST is selected, adviced by Lars-Peter Clausen
 - not to include head files which are unused actually in driver, adviced by Lars-Peter Clausen
 - I2S core just use one snd_soc_dai_driver struct, adviced by Lars-Peter Clausen
 - delete rockchip_pcm.c and related codes, use generic dmaengine API, adviced by Lars-Peter and Mark Brown
 - a driver should never attempt to change its own device name, just use
   the name that the kernel set, adviced by Lars-Peter and Mark Brown
 

 .../devicetree/bindings/sound/rockchip-i2s.txt     |   37 ++
 sound/soc/Kconfig                                  |    1 +
 sound/soc/Makefile                                 |    1 +
 sound/soc/rockchip/Kconfig                         |   12 +
 sound/soc/rockchip/Makefile                        |    4 +
 sound/soc/rockchip/rockchip_i2s.c                  |  531 ++++++++++++++++++++
 sound/soc/rockchip/rockchip_i2s.h                  |  223 ++++++++
 7 files changed, 809 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/rockchip-i2s.txt
 create mode 100644 sound/soc/rockchip/Kconfig
 create mode 100644 sound/soc/rockchip/Makefile
 create mode 100644 sound/soc/rockchip/rockchip_i2s.c
 create mode 100644 sound/soc/rockchip/rockchip_i2s.h

-- 
1.7.9.5



             reply	other threads:[~2014-07-11  9:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  9:54 jianqun [this message]
2014-07-11  9:54 ` [PATCH 1/2] ASoC: dt-bindings: add rockchip i2s bindings jianqun
2014-07-11  9:58 ` [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller jianqun
2014-07-11 10:03 ` [PATCH 0/2] add rockchip i2s driver Heiko Stübner
  -- strict thread matches above, loose matches on Subject: below --
2014-07-01  8:37 jianqun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405072489-20802-1-git-send-email-xjq@rock-chips.com \
    --to=xjq@rock-chips.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cf@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=heiko@sntech.de \
    --cc=hj@rock-chips.com \
    --cc=huangtao@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=kfx@rock-chips.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.de \
    --cc=yzq@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    --cc=zhenfu.fang@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®