From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735AbaGLB53 (ORCPT ); Fri, 11 Jul 2014 21:57:29 -0400 Received: from smtprelay0164.hostedemail.com ([216.40.44.164]:33780 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754529AbaGLB51 (ORCPT ); Fri, 11 Jul 2014 21:57:27 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:973:982:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3874:4250:4321:5007:6119:7652:7903:10004:10400:10848:11232:11658:11914:12043:12114:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: apple31_23b035b70a700 X-Filterd-Recvd-Size: 1774 Message-ID: <1405130244.6751.32.camel@joe-AO725> Subject: Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch From: Joe Perches To: Greg KH Cc: devel@driverdev.osuosl.org, kernel-janitors , kernelnewbies@kernelnewbies.org, LKML , Dan Carpenter , Andrew Morton Date: Fri, 11 Jul 2014 18:57:24 -0700 In-Reply-To: <20140712015327.GA26496@kroah.com> References: <1405128087.6751.12.camel@joe-AO725> <20140712015327.GA26496@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-07-11 at 18:53 -0700, Greg KH wrote: > On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote: > > A simple script to run checkpatch --fix for various types of > > of cleanups. [] > Anyway, try running this script on > drivers/staging/lustre/lnet/lnet/acceptor.c to see how this build fails. lustre doesn't use "normal" kernel makefiles. I supposed that the entire staging/lustre/ path could be built for every change, but for most of staging, and nearly all of the rest of the kernel tree, using: make file.o works. I know there can be many enhancements to the reformat script, but I think a minimally acceptable version is a decent start. So, thanks for trying it out. And keep the complaints coming. cheers, Joe