From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: <linux-kernel@vger.kernel.org>
Cc: Tejun Heo <tj@kernel.org>, Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [PATCH 0/1 V2] workqueue: a tiny fix for the mayday timer
Date: Mon, 14 Jul 2014 16:13:20 +0800 [thread overview]
Message-ID: <1405325601-12437-1-git-send-email-laijs@cn.fujitsu.com> (raw)
In-Reply-To: <1405265479-827-1-git-send-email-laijs@cn.fujitsu.com>
Hi, TJ
The del_timer_sync()s for the mayday timer in maybe_create_worker()
do not meet the requirement of the document of the del_timer_sync().
V1 patch incorrectly stops the timer when !need_to_create_worker(),
but no one can restart it when needed. In V2, we stops the
timer only when manager is not working.
Sorry for the incorrect V1 due to a general excuse: World-Cup-2014.
Another patch "[PATCH 1/1 V2] workqueue: unfold start_worker() into create_worker()"
depends on this patch. That patch still coincides with this patch even
this patch is updated.
Thanks,
Lai
Lai Jiangshan (1):
workqueue: remove the del_timer_sync()s in maybe_create_worker()
kernel/workqueue.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
--
1.7.4.4
next prev parent reply other threads:[~2014-07-14 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 15:31 [PATCH] workqueue: remove the del_timer_sync()s in maybe_create_worker() Lai Jiangshan
2014-07-14 8:13 ` Lai Jiangshan [this message]
2014-07-14 8:13 ` [PATCH 1/1 V2] " Lai Jiangshan
2014-07-14 14:27 ` Tejun Heo
2014-07-14 15:33 ` Thomas Gleixner
2014-07-14 21:18 ` Lai Jiangshan
2014-07-14 21:42 ` Thomas Gleixner
2014-07-15 0:22 ` Lai Jiangshan
2014-07-16 1:24 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405325601-12437-1-git-send-email-laijs@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®