mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: pramod.gurav.etc@gmail.com
To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: Pramod Gurav <pramod.gurav.etc@gmail.com>,
	Josh Cartwright <joshc@codeaurora.org>,
	Mark Brown <broonie@linaro.org>
Subject: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected
Date: Wed, 16 Jul 2014 17:09:57 +0530	[thread overview]
Message-ID: <1405510797-755-1-git-send-email-pramod.gurav.etc@gmail.com> (raw)

From: Pramod Gurav <pramod.gurav.etc@gmail.com>

REGMAP_SPMI module calls some functions from SPMI hence build breaks
when SPMI is not enabled while compiling REGMAP_SPMI with below linker
errors:

drivers/built-in.o: In function `regmap_spmi_ext_read':
:(.text+0x1143ec): undefined reference to `spmi_ext_register_read'
:(.text+0x11443c): undefined reference to `spmi_ext_register_readl'
drivers/built-in.o: In function `regmap_spmi_ext_gather_write':
:(.text+0x1144c4): undefined reference to `spmi_ext_register_write'
:(.text+0x114520): undefined reference to `spmi_ext_register_writel'
drivers/built-in.o: In function `regmap_spmi_base_read':
:(.text+0x1145b8): undefined reference to `spmi_register_read'
drivers/built-in.o: In function `regmap_spmi_base_gather_write':
:(.text+0x114630): undefined reference to `spmi_register_write'
:(.text+0x11465c): undefined reference to `spmi_register_zero_write'

Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
CC: Josh Cartwright <joshc@codeaurora.org>
CC: Mark Brown <broonie@linaro.org>
---
This was found when I enabled support for Qualcomm QPNP PMICs and was
compiling it. It selects REGMAP_SPMI and hence the crash.

 drivers/base/regmap/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index 4251570..1aa9d71 100644
--- a/drivers/base/regmap/Kconfig
+++ b/drivers/base/regmap/Kconfig
@@ -16,6 +16,7 @@ config REGMAP_SPI
 	tristate
 
 config REGMAP_SPMI
+	select SPMI
 	tristate
 
 config REGMAP_MMIO
-- 
1.7.9.5


             reply	other threads:[~2014-07-16 11:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 11:39 pramod.gurav.etc [this message]
2014-07-16 12:07 ` Stanimir Varbanov
2014-07-16 12:14   ` Pramod Gurav
2014-07-16 12:25     ` Stanimir Varbanov
2014-07-16 12:56       ` Pramod Gurav
2014-07-16 13:53         ` Stanimir Varbanov
2014-07-16 13:53         ` Mark Brown
2014-07-16 14:00           ` Ivan T. Ivanov
2014-07-16 14:18             ` Mark Brown
2014-07-16 14:42               ` pramod gurav
2014-07-16 14:48                 ` Mark Brown
2014-07-16 12:19 ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405510797-755-1-git-send-email-pramod.gurav.etc@gmail.com \
    --to=pramod.gurav.etc@gmail.com \
    --cc=broonie@linaro.org \
    --cc=joshc@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome