From: Igor Bezukh <igbzkh@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, forest@alittletooquiet.net,
linux-kernel@vger.kernel.org, igbzkh@gmail.com
Subject: [PATCH] Staging: vt6655: apply kernel coding style to wCommandTimerWait function
Date: Fri, 18 Jul 2014 21:35:13 +0300 [thread overview]
Message-ID: <1405708513-27831-1-git-send-email-igbzkh@gmail.com> (raw)
Since there is a lot of stuff that need to be changed in order to meet the kernel
coding style in wcmd.c file, I've decided to fix function-per-patch.
The following changes were made in vCommandTimerWait function:
- Camel case change:
- MSecond ---> msec
- hDdeviceContext ---> private
- pDevice ---> priv
- Removed redundant return
- Removed redndant comment
In future patches, I will also change the function name itself.
Signed-off-by: Igor Bezukh <igbzkh@gmail.com>
---
drivers/staging/vt6655/wcmd.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/vt6655/wcmd.c b/drivers/staging/vt6655/wcmd.c
index a689645..e5073d9 100644
--- a/drivers/staging/vt6655/wcmd.c
+++ b/drivers/staging/vt6655/wcmd.c
@@ -281,21 +281,15 @@ s_MgrMakeProbeRequest(
return pTxPacket;
}
-void
-vCommandTimerWait(
- void *hDeviceContext,
- unsigned int MSecond
-)
+void vCommandTimerWait(void *private, unsigned int msec)
{
- PSDevice pDevice = (PSDevice)hDeviceContext;
+ PSDevice priv = (PSDevice)private;
- init_timer(&pDevice->sTimerCommand);
- pDevice->sTimerCommand.data = (unsigned long) pDevice;
- pDevice->sTimerCommand.function = (TimerFunction)vCommandTimer;
- // RUN_AT :1 msec ~= (HZ/1024)
- pDevice->sTimerCommand.expires = (unsigned int)RUN_AT((MSecond * HZ) >> 10);
- add_timer(&pDevice->sTimerCommand);
- return;
+ init_timer(&priv->sTimerCommand);
+ priv->sTimerCommand.data = (unsigned long)priv;
+ priv->sTimerCommand.function = (TimerFunction)vCommandTimer;
+ priv->sTimerCommand.expires = (unsigned int)RUN_AT((msec * HZ) >> 10);
+ add_timer(&priv->sTimerCommand);
}
void
--
1.7.9.5
next reply other threads:[~2014-07-18 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 18:35 Igor Bezukh [this message]
2014-07-18 23:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405708513-27831-1-git-send-email-igbzkh@gmail.com \
--to=igbzkh@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome