mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: deller@gmx.de, tiwai@suse.de, jkosina@suse.cz, joe@perches.com,
	dave.anglin@bell.net, linux-parisc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: Remove FIXME comment
Date: Fri, 18 Jul 2014 14:03:34 -0700	[thread overview]
Message-ID: <1405717414.30262.12.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <1405715823-17492-1-git-send-email-xerofoify@gmail.com>

On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote:
> The comment for size of frame not being needed is incorrect , the
> function called needs this parameter.

Actually, that's not correct.  The point of the FIXME is that fram_size
is only used in a debug print and could be eliminated since the
internals of the function excluding the debugging statements don't use
it.

James



  parent reply	other threads:[~2014-07-18 21:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 20:37 Nicholas Krause
2014-07-18 20:49 ` Helge Deller
2014-07-18 21:03 ` James Bottomley [this message]
2014-07-19  2:25   ` Nick Krause
2014-07-19  5:20     ` James Bottomley
2014-07-19  5:28       ` Nick Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405717414.30262.12.camel@dabdike.int.hansenpartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=dave.anglin@bell.net \
    --cc=deller@gmx.de \
    --cc=jkosina@suse.cz \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®