From: Paul Bolle <pebolle@tiscali.nl>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: ralf@linux-mips.org, paul.burton@imgtec.com,
Leonid.Yegoshin@imgtec.com, markos.chandras@imgtec.com,
Steven.Hill@imgtec.com, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: Remove uneeded line in cmp_smp_finish
Date: Sat, 19 Jul 2014 14:05:56 +0200 [thread overview]
Message-ID: <1405771556.18077.5.camel@x220> (raw)
In-Reply-To: <1405746604-7737-1-git-send-email-xerofoify@gmail.com>
On Sat, 2014-07-19 at 01:10 -0400, Nicholas Krause wrote:
> This patch removes a unneeded line from this file as stated by the
> fix me in this file.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/mips/kernel/smp-cmp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/kernel/smp-cmp.c b/arch/mips/kernel/smp-cmp.c
> index fc8a515..61bfa20 100644
> --- a/arch/mips/kernel/smp-cmp.c
> +++ b/arch/mips/kernel/smp-cmp.c
> @@ -60,8 +60,6 @@ static void cmp_smp_finish(void)
> {
> pr_debug("SMPCMP: CPU%d: %s\n", smp_processor_id(), __func__);
>
> - /* CDFIXME: remove this? */
> - write_c0_compare(read_c0_count() + (8 * mips_hpt_frequency / HZ));
That comment ends in a question mark. I wonder why...
> #ifdef CONFIG_MIPS_MT_FPAFF
> /* If we have an FPU, enroll ourselves in the FPU-full mask */
Paul Bolle
next prev parent reply other threads:[~2014-07-19 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 5:10 Nicholas Krause
2014-07-19 12:05 ` Paul Bolle [this message]
2014-07-19 21:33 ` Nick Krause
2014-07-21 8:19 ` Paul Burton
2014-07-21 17:34 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405771556.18077.5.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=Steven.Hill@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome