From: Nadav Amit <namit@cs.technion.ac.il>
To: pbonzini@redhat.com
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, gleb@kernel.org, linux-kernel@vger.kernel.org,
Nadav Amit <namit@cs.technion.ac.il>
Subject: [PATCH kvm-unit-tests 3/3] x86: Check RFLAGS.RF on interrupt during REP-str
Date: Mon, 21 Jul 2014 14:39:54 +0300 [thread overview]
Message-ID: <1405942794-22681-4-git-send-email-namit@cs.technion.ac.il> (raw)
In-Reply-To: <1405942794-22681-1-git-send-email-namit@cs.technion.ac.il>
Intel SDM states (17.3.1.1): "For any interrupt arriving after any iteration of
a repeated string instruction but the last iteration, the value pushed for RF
is 1." This test checks whether it is performed correctly. Unfortunately,
there is no easy fix for this problem, since the hypervisor has no indication
whether any iteration was executed.
Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
---
x86/eventinj.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/x86/eventinj.c b/x86/eventinj.c
index 32de6f0..8fa4d84 100644
--- a/x86/eventinj.c
+++ b/x86/eventinj.c
@@ -54,6 +54,7 @@ static void flush_idt_page()
static volatile unsigned int test_divider;
static volatile int test_count;
+static volatile unsigned long rflags = 0;
ulong stack_phys;
void *stack_va;
@@ -190,6 +191,7 @@ static void tirq1(isr_regs_t *r)
{
printf("irq1 running\n");
test_count++;
+ rflags = r->rflags;
eoi();
}
@@ -208,6 +210,7 @@ int main()
{
unsigned int res;
ulong *pt, *cr3, i;
+ unsigned char src[10], dst[10];
setup_vm();
setup_idt();
@@ -291,6 +294,19 @@ int main()
printf("After vec 32 and 33 to self\n");
report("vec 32/33", test_count == 2);
+ /* Inject HW interrupt on rep-movs and check RF */
+ test_count = 0;
+ flush_idt_page();
+ printf("Sending vec 33 to self\n");
+ apic_self_ipi(33);
+ io_delay();
+ irq_enable();
+ asm volatile("rep movsb\n" : :
+ "S"(src), "D"(dst), "c"(10) : "memory", "cc");
+ irq_disable();
+ printf("After vec 33 to self\n");
+ report("rflags.rf during rep movsb", test_count == 1 &&
+ (rflags & (1<<16)));
/* Inject HW interrupt, do sti and than (while in irq shadow) inject
soft interrupt. Fault during soft interrupt. Soft interrup shoud be
--
1.9.1
next prev parent reply other threads:[~2014-07-21 11:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 11:37 [PATCH 0/7] KVM: x86: Additional rflags.rf fixes Nadav Amit
2014-07-21 11:37 ` [PATCH 1/7] KVM: x86: Defining missing x86 vectors Nadav Amit
2014-07-21 11:37 ` [PATCH 2/7] KVM: x86: Function for determining exception type Nadav Amit
2014-07-21 12:18 ` Paolo Bonzini
2014-07-21 21:30 ` Nadav Amit
2014-07-22 8:08 ` Paolo Bonzini
2014-07-21 11:37 ` [PATCH 3/7] KVM: x86: Clearing rflags.rf upon skipped emulated instruction Nadav Amit
2014-07-21 11:37 ` [PATCH 4/7] KVM: vmx: set rflags.rf during fault injection Nadav Amit
2014-07-21 12:05 ` Paolo Bonzini
2014-07-21 11:37 ` [PATCH 5/7] KVM: x86: popf emulation should not change RF Nadav Amit
2014-07-21 11:37 ` [PATCH 6/7] KVM: x86: Clear rflags.rf on emulated instructions Nadav Amit
2014-07-21 11:37 ` [PATCH 7/7] KVM: x86: Cleanup of rflags.rf cleaning Nadav Amit
2014-07-21 11:39 ` [PATCH kvm-unit-tests 0/3] x86: Test rflags.rf clearing/setting Nadav Amit
2014-07-21 11:39 ` [PATCH kvm-unit-tests 1/3] x86: Check rflags.rf is cleared after emulation Nadav Amit
2014-07-21 11:39 ` [PATCH kvm-unit-tests 2/3] x86: Test rflags.rf is set upon faults Nadav Amit
2014-07-21 12:24 ` Paolo Bonzini
2014-07-21 11:39 ` Nadav Amit [this message]
2014-07-21 12:25 ` [PATCH kvm-unit-tests 0/3] x86: Test rflags.rf clearing/setting Paolo Bonzini
2014-07-24 11:55 ` [PATCH kvm-unit-tests] x86: Test rflags.rf is set upon faults Nadav Amit
2014-07-24 12:09 ` Paolo Bonzini
2014-07-21 12:19 ` [PATCH 0/7] KVM: x86: Additional rflags.rf fixes Paolo Bonzini
2014-07-21 12:28 ` Nadav Amit
2014-07-21 12:31 ` Paolo Bonzini
2014-07-24 11:51 ` [PATCH 0/2] KVM: x86: Missing " Nadav Amit
2014-07-24 11:51 ` [PATCH 1/2] KVM: x86: Setting rflags.rf during rep-string emulation Nadav Amit
2014-07-24 11:51 ` [PATCH 2/2] KVM: x86: set rflags.rf during fault injection Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405942794-22681-4-git-send-email-namit@cs.technion.ac.il \
--to=namit@cs.technion.ac.il \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®