From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750846AbeAOXMi (ORCPT + 1 other); Mon, 15 Jan 2018 18:12:38 -0500 Received: from mout01.posteo.de ([185.67.36.65]:60780 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbeAOXMg (ORCPT ); Mon, 15 Jan 2018 18:12:36 -0500 From: Max Schulze Subject: Re: [PATCH v3] USB: serial: option: add id for Motorola Solutions TETRA PEI To: Johan Hovold Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180112092954.9161-1-max.schulze@posteo.de> <20180112171902.GC5992@localhost> Message-ID: <1405adb5-8e74-b02a-bf75-cf83bf6b3c91@posteo.de> Date: Tue, 16 Jan 2018 00:12:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180112171902.GC5992@localhost> Content-Type: text/plain; charset=utf-8 Content-Language: de-LU Content-Transfer-Encoding: 8bit Autocrypt: addr=max.schulze@posteo.de; keydata=xsFNBFZwMSMBEACvfjS9OuLRpIRt31AjZQex0c3TRiOeDMwT2HLtcROSr3yjYV4OLILrbtBJ07/yyEAGgK81HfJmFc5OEH8KgsMV+4qZ0xpl5lU3b5iqQM5TpV43Mlj0Btnm1nwt6SEP386VXNXLU50zGmf+xSYW44v62nZ6O6+BzgDlm1WDfHOgPbqnlTj0hnGhIaxWWHQfmxj4LJHgqq52p0UN9rKBgL60eSwCqpXPB5IaxqmL2SA7Un8vP1EXVCDNMvnrtNMJ2oaCqEITloIfuGRyeakmc+gZTpmEFA+wdoAK1iYKrJ/GWcBIsGW8NgMKgn6O5sP4slE2uNbv/pjORqelYMp50O9cWH3Kdoej2Iniho1nhhXD7/4lJtbYRLDxbq1De+/Mc+8S5EVTwjHbK2mOGlYxRSWqBkx6zLH5bj6fw42ITM8uZx/+earYC50vGqokiuAP10vlndtdhWkGkxcMFroFs/jpq3noa7ng/9QYpwqFV/KRfu0O2410H4zEpp7h4UHf2NxjTCumaDRTWoWE1GtH13D9Zr7w8A6iNSyL55/3Bc4xNlVVpqxYJAQR4qFYvQcP/Ox3eIpqUGMcCwp+6sx1v3O+DNJXZlXL6eolGPExODW6gaB1ndE+qfwMAfVC/vSIYkCS0E1rF/gk/kjSxnxImQ3xmyOQBFJl+sztgiHI44ny+wARAQABzS1tYXguc2NodWx6ZUBwb3N0ZW8uZGUgPG1heC5zY2h1bHplQHBvc3Rlby5kZT7CwXgEEwECACIFAlZwMSMCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJELOK1wf5Jjx40g0P/jJpD+9jJUweaOfT92kMPW9yA6/aRZuhQ2ouNESU5LD+QOlqRiLvpIYSyzu+PhKapvaQ18Z2shvA6hSVWBdGXgCwjormrvwms6l1Ldyuoar AWDvalvUSQZXim2/B6ZUoLC7GtHDFYRreszdhG3GfGIsZ06cK5X2Z9F7Fyz9ExL7qDcgiB0KLnMn19NvUeH21xmcmp50lMwdTWgjgj4VYfSpviPsFexeKYo3aDumC1I0WlVjzkC7Yz7U51gK7Xkms0/FurmWu+o2hDFBvfnL5NXQfPpvc5uDup2ViwKDxo0k/rCXqAN8sm5bTGh+QF2GRZjp3LNzPzH8yPMwpWAg+maMyjfbIVF95iB5WoZcYM7rDqZ5MV8yEZ3qkybXxnoe3X1Bs1naDMSGzbiUVoiO+9jdRgKfjC4GjVdHZ0ExNCzLuOICJbxa8McJPsg7lXaDJSiqwy0uIaTxMGHG2xSnw8FcR6cvgfi9knBktSV7v2BFARd/diZAT3bSjdwc7dIH8r9LWznvSExaDDQ07EEeM3uTZKlp9V7hbxQPhK98zVBwol37CPP6rOV2e5vXRA43wZG961xCK1HuJQtTDh92I7HiFChD/ApDWZ5TjTJdE6iIGhASiCYb4DG6IFyf8tcG55nWLjisfA7wkzP9yv3JP/20e72emhtfRwlOLZaeH2K2tzsFNBFZwMSMBEADIbYYq7ZoaRlLlhmIutwfdM91p+lctKfaXBgtMcB2l6oMh2AXioG3RJGd6t8/k5w4VsHcB6wN42fRKzqQxrc5V/ptr1LDQYxctVn31YB8zXjM5Ml7DEZXGoG3g+shryJsgX4tkot2r8r3zLXjrxSU0JaRgikSvdMxUVjRagG6aiUlr+piUqc8g/Ca5m7iZkNdlBvMPGh29F4UtHLfI1AmwoxlVUppwm4udXt8EZvGdjF8ce5uREFf9bVBhkgIHoWCOyFIjqjJECZSjB50xZ3bDg90u6QCPDOj3dH2EqNQS17sO19WR+xcoPhkMQ+gLYqts/hAte4S7j6Iy/mG33Kb6E78S0eEyLPEMJpzl3tCRcxHN5k+nYcbBuSoSd6qkwqb79KM8JZ8DHxoFTjTPZBqp PG3/y/jdUYp17RHM+AY/GFoDmE7VSBEVCRzCVHVGzZtYJgSIurEAyqOAf1JgqQc2hjhdmJBZrkzC3nuoTm/pBWO+kpwa7+BysxVLAF/sCQdm4gMGPmgPBDBdVIbSvKq3bBLqHyaMjILIbdVPwBtEX6+64SbP9QYbXxH0oBAXj3sHEnMQm97yDMEHmxZKGCdNjKszZqtLNHG4K3zhD1DAu0QUlyftzYnqIk5JcGGJIuIIbfkT+edon5VE7QdnQgWSNatzUnnj9ZvppiVphtAfWwARAQABwsFfBBgBAgAJBQJWcDEjAhsMAAoJELOK1wf5Jjx49KQP/AtPaNQwIp+ZFUTpvgAh12PdlBfjDL4KGFSpP6zY6M+ouI9tIPFEdGAreVMVd+8+K04coYI3P9sOctLHkrbKDYmtDhgbS8aRK6qimb1/ynBv3h4exfVvfvYI5o9YhevdB8Ow1nAwdyEkpLKy0tM8CPLcuUe+CjpJffb6s7cW21x4yclrfpviQeH1vaI6GJiu+cAfj5i052/r26R84mRWzFiS3NisFTnQ51qg/tbyp6rDml50K8EcC1iVdbhZtKDVhiOtl+1tVa6esS8USlDFmahNxAv8X84ZPavxq0XDU0J3oydWMYojgY5wbjzyK8yP7ylo49d52J31F3810r2B11U/5MjZHMrxPGwWH43OofIkL3EbviHpXCnf9SYQX5JRcUgEpxQdg+ciaDuMGzM9sCLA+nC6X+tIvPTSyZ+tvpRTWetUpYuDdsKtGIbeGWfJNWc2HXu+FR81uLrfRep65CzD387b0QZFbv2a9jgdBQ4vVLgcLF91P6VreKPgkFS0bzTNBji70PTJM+sjTgSPzsjv1VJUVzKOEM6fQ0eJIx+6SVoVOURJPG5bdMI4XwN3GG5tYbCxKtLG62Jkha4rxKmY4Kaf+jbQuAhjqmJiTgICE7VgUapjAgWpjf0OX+SsOF8rVfQYjIYgXKQRhH/1FYKaWmLNa +TnsDNfJtsvPDU4 OpenPGP: url=https://posteo.de/keys/max.schulze@posteo.de.asc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > This indicates that option isn't the right driver for this for device. > > I think we should add a new simple driver for it instead, which reports > that modem control isn't (yet) supported (yes, your python script would > need to be updated). This can be extended into a "real" driver, should > we learn more about the protocol used. Thank you. Tested with miniterm.py - it doesn't need any changes because no erroneous URB's are sent. [  172.249297] usb_serial_simple 1-1.4:1.0: motorola_tetra converter detected [  172.249403] usb 1-1.4: motorola_tetra converter now attached to ttyUSB0 [  172.249502] usb_serial_simple 1-1.4:1.1: motorola_tetra converter detected [  172.249578] usb 1-1.4: motorola_tetra converter now attached to ttyUSB1 > >From a7ab87acf85b67303e7bf606734176a365aae9cd Mon Sep 17 00:00:00 2001 > From: Johan Hovold > Date: Fri, 12 Jan 2018 17:53:35 +0100 > Subject: [PATCH] USB: serial: simple: add Motorola Tetra driver > > Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI > devices. > > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=0cad ProdID=9011 Rev=24.16 > S: Manufacturer=Motorola Solutions Inc. > S: Product=Motorola Solutions TETRA PEI interface > C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA > I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > > Note that these devices do not support the CDC SET_CONTROL_LINE_STATE > request (for any interface). > > Reported-by: Max Schulze > Cc: stable > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/Kconfig | 1 + > drivers/usb/serial/usb-serial-simple.c | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig > index a8d5f2e4878d..c66b93664d54 100644 > --- a/drivers/usb/serial/Kconfig > +++ b/drivers/usb/serial/Kconfig > @@ -63,6 +63,7 @@ config USB_SERIAL_SIMPLE > - Google USB serial devices > - HP4x calculators > - a number of Motorola phones > + - Motorola Tetra devices > - Novatel Wireless GPS receivers > - Siemens USB/MPI adapter. > - ViVOtech ViVOpay USB device. > diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c > index 74172fe158df..4ef79e29cb26 100644 > --- a/drivers/usb/serial/usb-serial-simple.c > +++ b/drivers/usb/serial/usb-serial-simple.c > @@ -77,6 +77,11 @@ DEVICE(vivopay, VIVOPAY_IDS); > { USB_DEVICE(0x22b8, 0x2c64) } /* Motorola V950 phone */ > DEVICE(moto_modem, MOTO_IDS); > > +/* Motorola Tetra driver */ > +#define MOTOROLA_TETRA_IDS() \ > + { USB_DEVICE(0x0cad, 0x9011) } /* Motorola Solutions TETRA PEI */ > +DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS); > + > /* Novatel Wireless GPS driver */ > #define NOVATEL_IDS() \ > { USB_DEVICE(0x09d7, 0x0100) } /* NovAtel FlexPack GPS */ > @@ -107,6 +112,7 @@ static struct usb_serial_driver * const serial_drivers[] = { > &google_device, > &vivopay_device, > &moto_modem_device, > + &motorola_tetra_device, > &novatel_gps_device, > &hp4x_device, > &suunto_device, > @@ -122,6 +128,7 @@ static const struct usb_device_id id_table[] = { > GOOGLE_IDS(), > VIVOPAY_IDS(), > MOTO_IDS(), > + MOTOROLA_TETRA_IDS(), > NOVATEL_IDS(), > HP4X_IDS(), > SUUNTO_IDS(), > -- > 2.15.1 > > -- Works as-is. Tested in miniterm.py and minicom. Tested-by: Max Schulze