From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Nick Krause <xerofoify@gmail.com>
Cc: drbd-dev@lists.linbit.com, drbd-user@lists.linbit.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: drbd_worker.c: Remove lines
Date: Tue, 22 Jul 2014 10:09:51 +0200 [thread overview]
Message-ID: <1406016591.23999.40.camel@marge.simpson.net> (raw)
In-Reply-To: <CAPDOMVikKnHvK-O+20dL1apM=Hi6bDqxn8uVcrhHtsE1sufRUw@mail.gmail.com>
On Tue, 2014-07-22 at 02:17 -0400, Nick Krause wrote:
> There seems to be two fix mes in function in wait_for_work. I was
> wondering can we remove these spinlocks?
Rather than ask someone else this question, take a look to see what the
lock protects and from whom. If protected thingy cannot possibly be
diddled concurrently, you'll know what to do, if it can be, you'll know
what to do. If you can't figure it out, move on to the next windmill
until the last one on the planet has been tilted or bounced off of :)
-Mike
next prev parent reply other threads:[~2014-07-22 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 6:17 Nick Krause
2014-07-22 8:09 ` Mike Galbraith [this message]
2014-07-22 17:43 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406016591.23999.40.camel@marge.simpson.net \
--to=umgwanakikbuti@gmail.com \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®