From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Thomas Ilsche <thomas.ilsche@tu-dresden.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 2/2] perf tools: Default to python version 2
Date: Fri, 25 Jul 2014 12:14:05 +0900 [thread overview]
Message-ID: <1406258045-25726-2-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1406258045-25726-1-git-send-email-namhyung@kernel.org>
According to PEP 394 recommendation [1], it's more portable to use
python2 rather than plain python to refer python binary version 2.
Since there're distros using python3 by default like Arch, and we
don't support python3 (yet), it'd be better using python2 explicitly.
[1] https://www.python.org/dev/peps/pep-0394
Suggested-by: Thomas Ilsche <thomas.ilsche@tu-dresden.de>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/config/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index e05d8f99424d..0f4b7fbc4852 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -122,7 +122,7 @@ endif
ifndef NO_LIBPYTHON
override PYTHON := \
- $(call get-executable-or-default,PYTHON,python)
+ $(call get-executable-or-default,PYTHON,python2)
override PYTHON_CONFIG := \
$(call get-executable-or-default,PYTHON_CONFIG,$(PYTHON)-config)
--
2.0.0
next prev parent reply other threads:[~2014-07-25 3:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 16:36 Perf: cannot overide PYTHON(_CONFIG) Thomas Ilsche
2014-07-25 3:14 ` [PATCH 1/2] perf tools: Fix make PYTHON override Namhyung Kim
2014-07-25 3:14 ` Namhyung Kim [this message]
2014-07-25 9:28 ` [PATCH 2/2] perf tools: Default to python version 2 Thomas Ilsche
2014-07-25 10:24 ` Namhyung Kim
2014-07-25 11:43 ` Thomas Ilsche
2014-07-28 0:06 ` Namhyung Kim
2014-07-28 11:11 ` Thomas Ilsche
2014-07-29 6:38 ` Namhyung Kim
2014-07-25 7:23 ` [PATCH 1/2] perf tools: Fix make PYTHON override Thomas Ilsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406258045-25726-2-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=thomas.ilsche@tu-dresden.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome