From: Alex Elder <elder@linaro.org>
To: akpm@linux-foundation.org
Cc: kay@vrfy.org, pmladek@suse.cz, john.stultz@linaro.org,
jack@suse.cz, linux-kernel@vger.kernel.org
Subject: [PATCH v7 2/7] printk: insert newline for truncated records
Date: Mon, 28 Jul 2014 08:29:15 -0500 [thread overview]
Message-ID: <1406554160-9562-3-git-send-email-elder@linaro.org> (raw)
In-Reply-To: <1406554160-9562-1-git-send-email-elder@linaro.org>
If a log record has LOG_PREFIX set, its predecessor record should be
terminated if it was marked LOG_CONT.
In msg_print_text(), this condition was being ignored, which would
lead to such records showing up combined when reading /dev/kmsg.
Fix this oversight.
Suggested-by: Petr Mládek <pmladek@suse.cz>
Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Petr Mládek <pmladek@suse.cz>
---
kernel/printk/printk.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index ffc9928..7dfa658 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1013,6 +1013,12 @@ static size_t msg_print_text(const struct printk_log *msg, enum log_flags prev,
newline = false;
}
+ if ((prev & LOG_CONT) && (msg->flags & LOG_PREFIX) && len < size) {
+ if (buf)
+ buf[len++] = '\n';
+ else
+ len++;
+ }
do {
const char *next = memchr(text, '\n', text_size);
size_t text_len;
--
1.9.1
next prev parent reply other threads:[~2014-07-28 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 13:29 [PATCH v7 0/7] printk: start simplifying some flags Alex Elder
2014-07-28 13:29 ` [PATCH v7 1/7] printk: report dropped messages on separate line Alex Elder
2014-07-28 13:29 ` Alex Elder [this message]
2014-07-28 13:29 ` [PATCH v7 3/7] printk: initialize syslog_prev and console_prev Alex Elder
2014-07-28 13:29 ` [PATCH v7 4/7] printk: LOG_CONT and LOG_NEWLINE are opposites Alex Elder
2014-07-28 13:29 ` [PATCH v7 5/7] printk: honor LOG_PREFIX in devkmsg_read() Alex Elder
2014-07-28 13:29 ` [PATCH v7 6/7] printk: honor LOG_PREFIX in msg_print_text() Alex Elder
2014-07-28 13:29 ` [PATCH v7 7/7] printk: correct some more typos Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406554160-9562-3-git-send-email-elder@linaro.org \
--to=elder@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=john.stultz@linaro.org \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome