From: Ian Abbott <abbotti@mev.co.uk>
To: driverdev-devel@linuxdriverproject.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hartleys@visionengravers.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 08/19] staging: comedi: amplc_pci230: remove PCI230_ADC_CONV
Date: Tue, 29 Jul 2014 12:58:16 +0100 [thread overview]
Message-ID: <1406635107-27950-9-git-send-email-abbotti@mev.co.uk> (raw)
In-Reply-To: <1406635107-27950-1-git-send-email-abbotti@mev.co.uk>
The macro `PCI230_ADC_CONV` is never used. Just remove it. (At one
time, the value was written to the `PCI230_ADCSWTRIG` register to
trigger a conversion, but any value would do, and the driver no longer
uses that register to trigger conversions anyway.)
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
---
drivers/staging/comedi/drivers/amplc_pci230.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c
index 7983a0d..e6744a5 100644
--- a/drivers/staging/comedi/drivers/amplc_pci230.c
+++ b/drivers/staging/comedi/drivers/amplc_pci230.c
@@ -362,12 +362,6 @@
#define PCI230_ADC_FIFOLEVEL_FULL 4096 /* FIFO size */
/*
- * Value to write to ADCSWTRIG to trigger ADC conversion in software trigger
- * mode. Can be anything.
- */
-#define PCI230_ADC_CONV 0xffff
-
-/*
* PCI230+ EXTFUNC values.
*/
/* Route EXTTRIG pin to external gate inputs. */
--
2.0.0
next prev parent reply other threads:[~2014-07-29 11:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 11:58 [PATCH 00/19] staging: comedi: amplc_pci230: tidy up a bit Ian Abbott
2014-07-29 11:58 ` [PATCH 01/19] staging: comedi: amplc_pci230: reformat a load of comments Ian Abbott
2014-07-29 11:58 ` [PATCH 02/19] staging: comedi: amplc_pci230: fix checkpatch line over 80 characters Ian Abbott
2014-07-29 11:58 ` [PATCH 03/19] staging: comedi: amplc_pci230: logical continuations should be on the previous line Ian Abbott
2014-07-29 11:58 ` [PATCH 04/19] staging: comedi: amplc_pci230: blank lines aren't necessary before a close brace '}' Ian Abbott
2014-07-29 11:58 ` [PATCH 05/19] staging: comedi: amplc_pci230: alignment should match open parenthesis Ian Abbott
2014-07-29 11:58 ` [PATCH 06/19] staging: comedi: amplc_pci230: usleep_range is preferred over udelay Ian Abbott
2014-07-29 11:58 ` [PATCH 07/19] staging: comedi: amplc_pci230: remove unused settling time constants Ian Abbott
2014-07-29 11:58 ` Ian Abbott [this message]
2014-07-29 11:58 ` [PATCH 09/19] staging: comedi: amplc_pci230: remove PCI230_TEST_BIT() Ian Abbott
2014-07-29 11:58 ` [PATCH 10/19] staging: comedi: amplc_pci230: add whitespace to register values Ian Abbott
2014-07-29 11:58 ` [PATCH 11/19] staging: comedi: amplc_pci230: don't begin line with binary operator Ian Abbott
2014-07-29 11:58 ` [PATCH 12/19] staging: comedi: amplc_pci230: omit '!= 0' from logical expressions Ian Abbott
2014-07-29 11:58 ` [PATCH 13/19] staging: comedi: amplc_pci230: remove unnecessary braces Ian Abbott
2014-07-30 0:34 ` Hartley Sweeten
2014-07-30 11:53 ` [PATCH 13/19 v2] " Ian Abbott
2014-07-30 13:41 ` Dan Carpenter
2014-07-30 14:04 ` Ian Abbott
2014-07-30 14:09 ` Dan Carpenter
2014-07-30 14:27 ` Ian Abbott
2014-07-30 16:15 ` Hartley Sweeten
2014-07-30 23:53 ` Greg Kroah-Hartman
2014-07-29 11:58 ` [PATCH 14/19] staging: comedi: amplc_pci230: remove some indentation in pci230_ai_check_chanlist() Ian Abbott
2014-07-29 11:58 ` [PATCH 15/19] staging: comedi: amplc_pci230: no need for '&function' Ian Abbott
2014-07-29 11:58 ` [PATCH 16/19] staging: comedi: amplc_pci230: add whitespace to pci230_boards[] Ian Abbott
2014-07-29 11:58 ` [PATCH 17/19] staging: comedi: amplc_pci230: no need to initialize named members to zero Ian Abbott
2014-07-29 11:58 ` [PATCH 18/19] staging: comedi: amplc_pci230: tidy up stuct pci230_private Ian Abbott
2014-07-29 11:58 ` [PATCH 19/19] staging: comedi: amplc_pci230: remove some unnecessary parentheses Ian Abbott
2014-07-30 11:55 ` [PATCH 19/19 v2] " Ian Abbott
2014-07-30 0:54 ` [PATCH 00/19] staging: comedi: amplc_pci230: tidy up a bit Hartley Sweeten
2014-07-30 12:00 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406635107-27950-9-git-send-email-abbotti@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®