From: jianqun <xjq@rock-chips.com>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.de, tbleung@chromium.org, dgreid@chromium.org,
kevin.strasser@intel.com, jarkko.nikula@linux.intel.com,
swarren@nvidia.com, ralph.birt@maximintegrated.com
Cc: heiko@sntech.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, xujianqun <xjq@rock-chips.com>
Subject: [PATCH] ASoC: max98090 not need to return fail if fail to request hpdet irq.
Date: Wed, 30 Jul 2014 09:50:10 +0800 [thread overview]
Message-ID: <1406685010-25108-1-git-send-email-xjq@rock-chips.com> (raw)
From: xujianqun <xjq@rock-chips.com>
Since hardware may not MUST to use IRQ pin of max98090 as jack detect, the
driver can work well without it, can report jack trigger to CPU by a GPIO.
But here driver will register fail caused by failed to request irq.
Signed-off-by: xujianqun <xjq@rock-chips.com>
---
sound/soc/codecs/max98090.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
index 566919c..bc124ff 100644
--- a/sound/soc/codecs/max98090.c
+++ b/sound/soc/codecs/max98090.c
@@ -2515,6 +2515,8 @@ static int max98090_probe(struct snd_soc_codec *codec)
max98090_add_widgets(codec);
+ return 0;
+
err_access:
return ret;
}
--
1.7.9.5
next reply other threads:[~2014-07-30 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 1:50 jianqun [this message]
2014-07-30 6:29 ` Jarkko Nikula
2014-07-30 9:00 ` Jianqun
2014-07-30 8:54 ` [PATCH] ASoC: max98090 add irq valid check jianqun
2014-07-30 14:21 ` [alsa-devel] " Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406685010-25108-1-git-send-email-xjq@rock-chips.com \
--to=xjq@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dgreid@chromium.org \
--cc=heiko@sntech.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=kevin.strasser@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ralph.birt@maximintegrated.com \
--cc=swarren@nvidia.com \
--cc=tbleung@chromium.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®