From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755399AbaHAMqh (ORCPT ); Fri, 1 Aug 2014 08:46:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54000 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754881AbaHAMqf (ORCPT ); Fri, 1 Aug 2014 08:46:35 -0400 From: jgross@suse.com To: JBottomley@parallels.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org Cc: Juergen Gross Subject: [V2 PATCH] Save command pool address of Scsi_Host Date: Fri, 1 Aug 2014 14:46:30 +0200 Message-Id: <1406897190-28427-1-git-send-email-jgross@suse.com> X-Mailer: git-send-email 1.8.4.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Juergen Gross If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed. scsi_find_host_cmd_pool() will locate it, but scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template. This will result in an access error when the host is removed. Avoid the problem by saving the address of a new allocated command pool where it is expected. Signed-off-by: Juergen Gross --- drivers/scsi/scsi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 88d46fe..e8e8428 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -380,6 +380,10 @@ scsi_alloc_host_cmd_pool(struct Scsi_Host *shost) pool->slab_flags |= SLAB_CACHE_DMA; pool->gfp_mask = __GFP_DMA; } + + if (hostt->cmd_size) + hostt->cmd_pool = pool; + return pool; } -- 1.8.4.5