mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Yao <ryao@gentoo.org>
To: kernel@gentoo.org
Cc: mthode@mthode.org, michael@fds-team.de, drobbins@funtoo.org,
	viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/1] vfs: Respect MS_RDONLY at bind mount creation
Date: Fri,  1 Aug 2014 14:12:24 -0400	[thread overview]
Message-ID: <1406916744-6634-2-git-send-email-ryao@gentoo.org> (raw)
In-Reply-To: <1406916744-6634-1-git-send-email-ryao@gentoo.org>

`mount -o bind,ro ...` suffers from a silent failure where the readonly
flag is ignored. The bind mount will be created rw whenever the target
is rw. Users typically workaround this by remounting readonly, but that
does not work when you want to define readonly bind mounts in fstab.
This is a major annoyance when dealing with recursive bind mounts
because the userland mount command does not expose the option to
recursively remount a subtree as readonly.

Signed-off-by: Richard Yao <ryao@gentoo.org>
---
 fs/namespace.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 182bc41..0d23525 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1827,11 +1827,12 @@ static bool has_locked_children(struct mount *mnt, struct dentry *dentry)
  * do loopback mount.
  */
 static int do_loopback(struct path *path, const char *old_name,
-				int recurse)
+				unsigned long flags)
 {
 	struct path old_path;
-	struct mount *mnt = NULL, *old, *parent;
+	struct mount *mnt = NULL, *old, *parent, *m;
 	struct mountpoint *mp;
+	int recurse = flags & MS_REC;
 	int err;
 	if (!old_name || !*old_name)
 		return -EINVAL;
@@ -1871,6 +1872,10 @@ static int do_loopback(struct path *path, const char *old_name,
 		goto out2;
 	}
 
+	if (flags & MS_RDONLY)
+		for (m = mnt; m; m = (recurse ? next_mnt(m, mnt) : NULL))
+			mnt_make_readonly(m);
+
 	mnt->mnt.mnt_flags &= ~MNT_LOCKED;
 
 	err = graft_tree(mnt, parent, mp);
@@ -2444,7 +2449,8 @@ long do_mount(const char *dev_name, const char *dir_name,
 		retval = do_remount(&path, flags & ~MS_REMOUNT, mnt_flags,
 				    data_page);
 	else if (flags & MS_BIND)
-		retval = do_loopback(&path, dev_name, flags & MS_REC);
+		retval = do_loopback(&path, dev_name, flags & (MS_REC |
+							       MS_RDONLY));
 	else if (flags & (MS_SHARED | MS_PRIVATE | MS_SLAVE | MS_UNBINDABLE))
 		retval = do_change_type(&path, flags);
 	else if (flags & MS_MOVE)
-- 
1.8.5.5


  reply	other threads:[~2014-08-01 18:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 18:12 [PATCH v2 0/1] " Richard Yao
2014-08-01 18:12 ` Richard Yao [this message]
2014-08-01 19:20   ` [PATCH v2 1/1] " Mateusz Guzik
2014-08-01 20:33     ` Richard Yao
2014-08-02  3:55     ` [PATCH v3 0/1] " Richard Yao
2014-08-02  3:55       ` [PATCH v3 1/1] " Richard Yao
2014-08-02  8:18         ` Mateusz Guzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406916744-6634-2-git-send-email-ryao@gentoo.org \
    --to=ryao@gentoo.org \
    --cc=drobbins@funtoo.org \
    --cc=kernel@gentoo.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@fds-team.de \
    --cc=mthode@mthode.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®