mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniele Forsi <dforsi@gmail.com>
To: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Cc: Daniele Forsi <dforsi@gmail.com>
Subject: [PATCH] arch/x86/kernel/cpu/cyrix.c: remove redundant code
Date: Sat,  2 Aug 2014 16:44:31 +0200	[thread overview]
Message-ID: <1406990672-2382-1-git-send-email-dforsi@gmail.com> (raw)

This function doesn't read dir1 so it doesn't need to set a default
value and code for case 3 and case 5 is identical so replace it with
a "fall through" comment.

Signed-off-by: Daniele Forsi <dforsi@gmail.com>
---
 arch/x86/kernel/cpu/cyrix.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/cpu/cyrix.c b/arch/x86/kernel/cpu/cyrix.c
index aaf152e..6026664 100644
--- a/arch/x86/kernel/cpu/cyrix.c
+++ b/arch/x86/kernel/cpu/cyrix.c
@@ -167,16 +167,14 @@ static void geode_configure(void)
 
 static void early_init_cyrix(struct cpuinfo_x86 *c)
 {
-	unsigned char dir0, dir0_msn, dir1 = 0;
+	unsigned char dir0, dir0_msn, dir1;
 
 	__do_cyrix_devid(&dir0, &dir1);
 	dir0_msn = dir0 >> 4; /* identifies CPU "family"   */
 
 	switch (dir0_msn) {
 	case 3: /* 6x86/6x86L */
-		/* Emulate MTRRs using Cyrix's ARRs. */
-		set_cpu_cap(c, X86_FEATURE_CYRIX_ARR);
-		break;
+		/* Fall through */
 	case 5: /* 6x86MX/M II */
 		/* Emulate MTRRs using Cyrix's ARRs. */
 		set_cpu_cap(c, X86_FEATURE_CYRIX_ARR);
-- 
2.0.1


                 reply	other threads:[~2014-08-02 14:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406990672-2382-1-git-send-email-dforsi@gmail.com \
    --to=dforsi@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome