From: Waiman Long <Waiman.Long@hp.com>
To: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-doc@vger.kernel.org, Davidlohr Bueso <davidlohr@hp.com>,
Jason Low <jason.low2@hp.com>,
Scott J Norton <scott.norton@hp.com>,
Waiman Long <Waiman.Long@hp.com>
Subject: [PATCH 2/7] locking/rwsem: more aggressive use of optimistic spinning
Date: Sun, 3 Aug 2014 22:36:17 -0400 [thread overview]
Message-ID: <1407119782-41119-3-git-send-email-Waiman.Long@hp.com> (raw)
In-Reply-To: <1407119782-41119-1-git-send-email-Waiman.Long@hp.com>
The rwsem_can_spin_on_owner() function currently allows optimistic
spinning only if the owner field is defined and is running. That is
too conservative as it will cause some tasks to miss the opportunity
of doing spinning in case the owner hasn't been able to set the owner
field in time or the lock has just become available.
This patch enables more aggressive use of optimistic spinning by
assuming that the lock is spinnable unless proved otherwise.
Signed-off-by: Waiman Long <Waiman.Long@hp.com>
---
kernel/locking/rwsem-xadd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/locking/rwsem-xadd.c b/kernel/locking/rwsem-xadd.c
index d058946..dce22b8 100644
--- a/kernel/locking/rwsem-xadd.c
+++ b/kernel/locking/rwsem-xadd.c
@@ -285,7 +285,7 @@ static inline bool rwsem_try_write_lock_unqueued(struct rw_semaphore *sem)
static inline bool rwsem_can_spin_on_owner(struct rw_semaphore *sem)
{
struct task_struct *owner;
- bool on_cpu = false;
+ bool on_cpu = true; /* Assume spinnable unless proved not to be */
if (need_resched())
return false;
--
1.7.1
next prev parent reply other threads:[~2014-08-04 2:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 2:36 [PATCH 0/7] locking/rwsem: enable reader opt-spinning & writer respin Waiman Long
2014-08-04 2:36 ` [PATCH 1/7] locking/rwsem: don't resched at the end of optimistic spinning Waiman Long
2014-08-04 7:55 ` Peter Zijlstra
2014-08-04 18:36 ` Waiman Long
2014-08-04 20:48 ` Peter Zijlstra
2014-08-04 21:12 ` Jason Low
2014-08-05 17:54 ` Waiman Long
2014-08-04 2:36 ` Waiman Long [this message]
2014-08-04 4:09 ` [PATCH 2/7] locking/rwsem: more aggressive use " Davidlohr Bueso
2014-08-04 4:10 ` Jason Low
2014-08-04 15:44 ` Waiman Long
2014-08-13 5:51 ` Dave Chinner
2014-08-13 16:41 ` Waiman Long
2014-08-15 3:34 ` Dave Chinner
2014-08-15 17:58 ` Waiman Long
2014-08-16 7:40 ` Mike Galbraith
2014-08-17 23:41 ` Dave Chinner
2014-08-18 22:48 ` Waiman Long
2014-08-04 2:36 ` [PATCH 3/7] locking/rwsem: check for active writer/spinner before wakeup Waiman Long
2014-08-04 21:20 ` Jason Low
2014-08-05 17:56 ` Waiman Long
2014-08-04 2:36 ` [PATCH 4/7] locking/rwsem: threshold limited spinning for active readers Waiman Long
2014-08-05 4:54 ` Davidlohr Bueso
2014-08-05 5:30 ` Davidlohr Bueso
2014-08-05 5:41 ` Davidlohr Bueso
2014-08-05 18:14 ` Waiman Long
2014-08-04 2:36 ` [PATCH 5/7] locking/rwsem: move down rwsem_down_read_failed function Waiman Long
2014-08-04 2:36 ` [PATCH 6/7] locking/rwsem: enables optimistic spinning for readers Waiman Long
2014-08-04 2:36 ` [PATCH 7/7] locking/rwsem: allow waiting writers to go back to optimistic spinning Waiman Long
2014-08-04 4:25 ` [PATCH 0/7] locking/rwsem: enable reader opt-spinning & writer respin Davidlohr Bueso
2014-08-04 18:07 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407119782-41119-3-git-send-email-Waiman.Long@hp.com \
--to=waiman.long@hp.com \
--cc=davidlohr@hp.com \
--cc=jason.low2@hp.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=scott.norton@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®