From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131AbaHDPLU (ORCPT ); Mon, 4 Aug 2014 11:11:20 -0400 Received: from smtprelay0129.hostedemail.com ([216.40.44.129]:54797 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750949AbaHDPLT (ORCPT ); Mon, 4 Aug 2014 11:11:19 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:41:355:379:541:599:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:3868:3871:3872:3874:4321:5007:7652:10004:10400:10848:11232:11658:11914:12043:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: aunt97_b43b7b023d02 X-Filterd-Recvd-Size: 1667 Message-ID: <1407165075.16152.70.camel@joe-AO725> Subject: Re: checkpatch.pl report about "Missing blank line after declarations" in a structure definition From: Joe Perches To: Dotan Barak Cc: "linux-kernel@vger.kernel.org" Date: Mon, 04 Aug 2014 08:11:15 -0700 In-Reply-To: References: <3219ba81002f41d99c8651755dc2a920@DB3PR05MB380.eurprd05.prod.outlook.com> <1407159342.16152.63.camel@joe-AO725> <1407162439.16152.67.camel@joe-AO725> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-08-04 at 14:50 +0000, Dotan Barak wrote: > I think that allowing a prefix is reasonable (to allow modules to add more flexibility). > I tried the suggested change and it still didn't work for me. > > The following change worked for me: > (?:$Storage\s+)?[A-Z0-9_]*(?:DECLARE|DEFINE)_[A-Z_]*\s*\(| > > But, maybe it is better to be even more general and allow: > (?:$Storage\s+)?[A-Z0-9_]*(?:DECLARE|DEFINE)_[ A-Z0-9_]*\s*\(| Maybe: (?:$Storage\s+)(?:[A-Z_][A-Z0-9]+_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,2}