From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dotan Barak <dotanb@mellanox.com>,
Andy Whitcroft <apw@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Add uninitialized_var to the declaration_macro list
Date: Mon, 04 Aug 2014 09:02:31 -0700 [thread overview]
Message-ID: <1407168151.16152.77.camel@joe-AO725> (raw)
In-Reply-To: <1407138992.16152.53.camel@joe-AO725>
On Mon, 2014-08-04 at 00:56 -0700, Joe Perches wrote:
> Using uninitialized_var reports a false positive for
> "Missing blank line after declarations".
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> +our $declaration_macros = qr{(?x:
> + (?:$Storage\s+)?(?:DECLARE|DEFINE)_[A-Z]+\s*\(|
Hey Andrew.
Dotan showed some variants that could be added to this
line. Do you want it rolled into a V2 of this patch
or as a separate patch?
next prev parent reply other threads:[~2014-08-04 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9084ad9a17844ed898132853d161b495@DB3PR05MB380.eurprd05.prod.outlook.com>
2014-08-04 7:56 ` Joe Perches
2014-08-04 16:02 ` Joe Perches [this message]
2014-08-04 23:55 ` [PATCH V2] checkpatch: Update $declaration_macros, add uninitialized_var Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407168151.16152.77.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dotanb@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®