From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3764F2773EE for ; Thu, 12 Mar 2026 20:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773348979; cv=none; b=PIgO1r9Li97TIpIUNjoC2dfdjK+0TfO1h+UQtZtJPPEKB54U3/UZT0r7x3vM0/mWRCHGLynH02RJ/IT/2Gq6GNGdAfzM7ujf+4M8N+ykkIt0okPNnT9qfg5J6dKdQzzqUBUD00jJVXKQuuidlXgBV7OTPoezzczKJBJe9i7tRRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773348979; c=relaxed/simple; bh=I81kaNjLYEhYWPtg1AvVrZiAGxn58AVvypr+CpHj37s=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=Yi665uKKM5EmOrihyhGzvnq4m3zzmCseC9pZeGcgfDUdT/4XlAzgeN1a8RnT6599PLN/PENzSuQuEKXZVwbiuzoeq7tbVh329Epv6JGtcMTPQF2BCWtYkggZJIm2vAxGv7VaTd7m0Y4TMwgF5I2psiPrSdretYONFMpHh5/9gz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aXjz4CR7; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aXjz4CR7" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-506a747448dso12780821cf.0 for ; Thu, 12 Mar 2026 13:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773348977; x=1773953777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=I81kaNjLYEhYWPtg1AvVrZiAGxn58AVvypr+CpHj37s=; b=aXjz4CR7tyxdN67ivuVEvORWBH3Jjm4pffOXqz5aUju/6JSQWNeNUgLWkBWyynUtLt StoeGg83klViu8HwxPHHGv1CGSdexVkH8NtdBu03qrhR63KUj6+DQaeeP+FicVb9WY7l wJaqaPOl7uyQqFH5apcGjlXJYGyrXUpuQeckfZKCQBjJg6DDG2D6xBNlHmHG1RbNxXGE 4S0NK1VUCPZdv+5z8DuleshznH8lWfN/nalWIhmexEwbHcuZ0c9fwSaNcbyhTKVBK27S LkfZg6Jp2edhSFqd6dN4KVweJUYtlkVLA3Y1vpTKdHgLiyZzbU0F0EWdCr3L9WDGfvoC lk4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773348977; x=1773953777; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=I81kaNjLYEhYWPtg1AvVrZiAGxn58AVvypr+CpHj37s=; b=FB9TYFQ+4S3o/giuT+RCgH6sz7Aq1mKEoXkM+b1qMt9HUi4NFqtEbdlF+nhXf3LfE2 Um61lyabLvc9CPZODSZkzRDu8IDRc6o+5fdSJOEHa4J2wFjrnQ8625R1P1k9sy6dUR3b MJk5kTjUGDzf1PBIo8MD7LjFzr9vyJ9vdg+eQNxGZF3Wl5iIrk3epKYCGzsDfCszk5cU N4HESM3s0IvsrRCVFuFYzt+t72adUBY5/+cHECXpCnjXm+dH7GPf4ylE5MI6HOBTZ+g3 TxgNycyqBIVoqmWeuMheULoOouIe5UlzM/dAT4WxJt634O+i+YwKrlQyCacxgYEZ2Ujl iysg== X-Forwarded-Encrypted: i=1; AJvYcCVoC/tdBgw6XV69ZkWRj5+gjmusrTlvWBFx6rscdErGnrkx0hmTgMuXSk/LUBiGUgd9BvrWZZk6IP8nzrI=@vger.kernel.org X-Gm-Message-State: AOJu0YwTEDJL0HJRKAfWBqokZc8Ys/V4HVMtUWBUX+DlDLCPk/CvVBUg OtKf4pdjEyts45l57GFhxmMh2dIqEJ2TDAbeXfAyMqWwLUFCMgMY81mZ X-Gm-Gg: ATEYQzxhJpg4cKACYexw+lxdkqYeLjJTfnoWHqdKXNIXptdSWKVGcl+lwA9i89/DzAx 0N+aAdMJmUtLPej4Hg2Yq7zShgCPCLdz57ZR5SWqztnIFWq8DD+AZJcoZyKLf3P6/BwqTCRx4q6 7hymMGNWYBx7pWjXXpFMPjdFIS/47q7XQlhM2o5u8HtQttyJ6xk+mfcMIAtVkEBAn59RvlkwMdt qjquC8EYkQ6vFn6Fvi1mUSgfujiryyW8v7RhKU11V3Uy58Sra6qdwpvHd74Vf2SstGJTG+5t/QF 9Xb8/BtjQ7jw4pDhb3HCFAVweDc4oR49w0qguT3MkDi0c44ZCvLEV/6RrzNQIqQSFjBnd8dSq+L PrzOZeKZW8R0/CwMzrI7EUJasJ/5Y2E01TUouwyvWkVvw+H8K/W2kyVoxHc2+Ppl6eer2/9sWEE wcqMP9/15RTbV3k3u2tDrifrN4zH2CxD5T3iLt X-Received: by 2002:a05:622a:244:b0:509:38d2:858c with SMTP id d75a77b69052e-50957e10b71mr12563371cf.61.1773348977030; Thu, 12 Mar 2026 13:56:17 -0700 (PDT) Received: from ?IPv6:::1? ([2a00:23ee:2968:90cb:1c6d:1979:bcad:501a]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a65d1a3e5sm40190786d6.50.2026.03.12.13.56.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 13:56:16 -0700 (PDT) Date: Thu, 12 Mar 2026 20:56:13 +0000 From: Josh Law To: Andrew Morton Cc: "Liam R . Howlett" , Alice Ryhl , Andrew Ballance , Josh Law , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Message-ID: <14071af4-6886-43ac-8502-5f5c9763cc5b@gmail.com> In-Reply-To: References: <20260312184054.23481-1-objecting@objecting.org> <20260312134531.49c1f9171b4b0bc8352e678d@linux-foundation.org> Subject: Re: [PATCH 1/3] lib/maple_tree: fix potential NULL dereference in mas_pop_node() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <14071af4-6886-43ac-8502-5f5c9763cc5b@gmail.com> 12 Mar 2026 20:49:21 Josh Law : > 12 Mar 2026 20:45:32 Andrew Morton : > >> On Thu, 12 Mar 2026 18:40:53 +0000 Josh Law wrot= e: >> >>> If kmem_cache_alloc_from_sheaf() returns NULL (possible under >>> GFP_NOWAIT pressure), mas_pop_node() falls through to the out label >>> and dereferences the NULL pointer in memset(ret, 0, sizeof(*ret)). >> >> This is such a glaring bug that I wonder if we're missing something. >> >>> Add a WARN_ON_ONCE NULL check after the sheaf allocation to bail out >>> early, matching the existing pattern for the !mas->sheaf case above. >>> >>> Signed-off-by: Josh Law >>> --- >>> lib/maple_tree.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >>> index 739918e859e5..87a2ba6468ca 100644 >>> --- a/lib/maple_tree.c >>> +++ b/lib/maple_tree.c >>> @@ -1063,6 +1063,8 @@ static __always_inline struct maple_node *mas_pop= _node(struct ma_state *mas) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return NULL; >>> >>> =C2=A0=C2=A0=C2=A0 ret =3D kmem_cache_alloc_from_sheaf(maple_node_cache= , GFP_NOWAIT, mas->sheaf); >>> +=C2=A0=C2=A0 if (WARN_ON_ONCE(!ret)) >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return NULL; >> >> If we're going to do this then we may as well restore !__GFP_NOWARN, >> get more relevant information. >> >> But a GFP_NOWAIT allocation attempt can fail relatively easily so >> callers must be equipped to handle it - perhaps no need for any >> warning. > > Well, fair enough, but WARN_ON is equivalent to a "oops! Something went w= rong! We will continue anyway", NOWARN is quite bad for logging that that w= ent wrong, usually it's BUG_ON that causes said kernel panics and that, whi= ch is a bit overkill, that's why I didn't add it, and it warns once, then b= ails, that's why I'm a bit on the iffy side about adding NOWARN, what's you= r opinion on this, do you think a NOWARN is better then warn on once? > > > V/R > > > > Josh law I checked the callers as you suggested. In lib/maple_tree.c at lines 2352 a= nd 6039, mas_pop_node() is called inside loops where the return value is us= ed immediately (passed to ma_mnode_ptr or bitwise-ORed) without any NULL va= lidation. If kmem_cache_alloc_from_sheaf() fails under GFP_NOWAIT pressure, these cal= lers will trigger a kernel panic.