From: Thierry Reding <thierry.reding@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] PCI/AER: Make linux/aer.h standalone includable
Date: Tue, 5 Aug 2014 14:08:55 +0200 [thread overview]
Message-ID: <1407240535-19564-1-git-send-email-thierry.reding@gmail.com> (raw)
From: Thierry Reding <treding@nvidia.com>
The header file references u16, u32 and struct pci_dev types, but they
are not defined in the header nor does the header pull in the necessary
includes for them. This causes build breakage when the file is included
without any of the dependencies being satisfied from somewhere else.
Fix this by including linux/types.h (for u16 and u32) and by adding a
forward-declaration of struct pci_dev.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
include/linux/aer.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/linux/aer.h b/include/linux/aer.h
index 4dbaa7081530..04bcf33a3e3a 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -7,6 +7,10 @@
#ifndef _AER_H_
#define _AER_H_
+#include <linux/types.h>
+
+struct pci_dev;
+
#define AER_NONFATAL 0
#define AER_FATAL 1
#define AER_CORRECTABLE 2
--
2.0.4
next reply other threads:[~2014-08-05 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 12:08 Thierry Reding [this message]
2014-09-04 21:58 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407240535-19564-1-git-send-email-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome