From: Joe Perches <joe@perches.com>
To: Dzonatans Melgalvis <dz.melgalvis@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: comedidev.h: fix checkpatch code style issue
Date: Tue, 05 Aug 2014 19:31:15 -0700 [thread overview]
Message-ID: <1407292275.16152.115.camel@joe-AO725> (raw)
In-Reply-To: <1407281385-12576-1-git-send-email-dz.melgalvis@gmail.com>
On Wed, 2014-08-06 at 02:29 +0300, Dzonatans Melgalvis wrote:
> Fixing checkpatch warning - blank line missing after declaration.
These are false positives from a previous version
of checkpatch. Please use the version in -next
instead. No errors are reported with that version.
> Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 58e58a3..c9b7978 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -57,6 +57,7 @@ struct comedi_subdevice {
> const unsigned int *maxdata_list; /* list is channel specific */
>
> const struct comedi_lrange *range_table;
> +
> const struct comedi_lrange *const *range_table_list;
>
> unsigned int *chanlist; /* driver-owned chanlist (not used) */
> @@ -207,8 +208,10 @@ struct comedi_async {
> struct comedi_cmd cmd;
> wait_queue_head_t wait_head;
> unsigned int cb_mask;
> +
> int (*inttrig)(struct comedi_device *dev, struct comedi_subdevice *s,
> unsigned int x);
> +
> };
>
> struct comedi_driver {
> @@ -216,13 +219,16 @@ struct comedi_driver {
>
> const char *driver_name;
> struct module *module;
> +
> int (*attach)(struct comedi_device *, struct comedi_devconfig *);
> void (*detach)(struct comedi_device *);
> int (*auto_attach)(struct comedi_device *, unsigned long);
>
> /* number of elements in board_name and board_id arrays */
> unsigned int num_names;
> +
> const char *const *board_name;
> +
> /* offset in bytes from one board name pointer to the next */
> int offset;
> };
prev parent reply other threads:[~2014-08-06 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 23:29 Dzonatans Melgalvis
2014-08-05 23:35 ` Greg KH
2014-08-06 2:31 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407292275.16152.115.camel@joe-AO725 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=dz.melgalvis@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®