From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524AbaHFHMM (ORCPT ); Wed, 6 Aug 2014 03:12:12 -0400 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:36312 "EHLO lgemrelse6q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755099AbaHFHLU (ORCPT ); Wed, 6 Aug 2014 03:11:20 -0400 X-Original-SENDERIP: 10.177.220.145 X-Original-MAILFROM: iamjoonsoo.kim@lge.com From: Joonsoo Kim To: Andrew Morton Cc: "Kirill A. Shutemov" , Rik van Riel , Mel Gorman , Johannes Weiner , Minchan Kim , Yasuaki Ishimatsu , Zhang Yanfei , "Srivatsa S. Bhat" , Tang Chen , Naoya Horiguchi , Bartlomiej Zolnierkiewicz , Wen Congyang , Marek Szyprowski , Michal Nazarewicz , Laura Abbott , Heesub Shin , "Aneesh Kumar K.V" , Ritesh Harjani , t.stanislaws@samsung.com, Gioh Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim Subject: [PATCH v2 8/8] mm/isolation: remove useless race handling related to pageblock isolation Date: Wed, 6 Aug 2014 16:18:37 +0900 Message-Id: <1407309517-3270-12-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1407309517-3270-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1407309517-3270-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a mistake on moving freepage from normal buddy list to isolate buddy list. If we move page from normal buddy list to isolate buddy list, We should subtract freepage count in this case, but, it didn't. And, previous patches ('mm/isolation: close the two race problems related to pageblock isolation' and 'mm/isolation: change pageblock isolation logic to fix freepage counting bugs') solves the race related to pageblock isolation. So, this misplacement cannot happen and this workaround aren't needed anymore. Signed-off-by: Joonsoo Kim --- mm/page_isolation.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 063f1f9..48c8836 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -351,20 +351,6 @@ __test_page_isolated_in_pageblock(unsigned long pfn, unsigned long end_pfn, } page = pfn_to_page(pfn); if (PageBuddy(page)) { - /* - * If race between isolatation and allocation happens, - * some free pages could be in MIGRATE_MOVABLE list - * although pageblock's migratation type of the page - * is MIGRATE_ISOLATE. Catch it and move the page into - * MIGRATE_ISOLATE list. - */ - if (get_freepage_migratetype(page) != MIGRATE_ISOLATE) { - struct page *end_page; - - end_page = page + (1 << page_order(page)) - 1; - move_freepages(page_zone(page), page, end_page, - MIGRATE_ISOLATE); - } pfn += 1 << page_order(page); } else if (skip_hwpoisoned_pages && PageHWPoison(page)) { /* -- 1.7.9.5