From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755992AbaHHG6c (ORCPT ); Fri, 8 Aug 2014 02:58:32 -0400 Received: from g4t3426.houston.hp.com ([15.201.208.54]:39842 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbaHHG62 (ORCPT ); Fri, 8 Aug 2014 02:58:28 -0400 Message-ID: <1407481104.2513.41.camel@buesod1.americas.hpqcorp.net> Subject: Re: [PATCH 2/4 v2] brd: Add getgeo to block ops From: Davidlohr Bueso To: Boaz Harrosh Cc: One Thousand Gnomes , Jens Axboe , Ross Zwisler , Matthew Wilcox , linux-kernel , linux-fsdevel Date: Thu, 07 Aug 2014 23:58:24 -0700 In-Reply-To: References: <53E21125.9080308@plexistor.com> <53E211D9.7030102@plexistor.com> <53E3871C.4020008@plexistor.com> <20140807192032.70e71fa7@alan.etchedpixels.co.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-08-08 at 09:52 +0300, Boaz Harrosh wrote: > On Thu, Aug 7, 2014 at 9:20 PM, One Thousand Gnomes > wrote: > > On Thu, 07 Aug 2014 17:03:08 +0300 > > Boaz Harrosh wrote: > > > >> From: Boaz Harrosh > >> > >> Some programs like fdisk, require HDIO_GETGEO to work, which requires we > >> implement getgeo. > >> > >> We set all hd_geometry members to 1, because this way fdisk > >> math will not try its crazy geometry math and get stuff totally wrong. > > > > If you are running a new storage system for god sake don't use DOS > > partitioning, use GPT or something sane. > > > > I am always using GPT, on all my systems for few years now. > Fdisk works exactly the same, regardless of format, regarding alignment > and start sectors. Yes, fdisk now supports GPT, for about the past two years now. In fact it has been completely rewritten.