From: Benoit Taine <benoit.taine@lip6.fr>
To: bhelgaas@google.com
Cc: benoit.taine@lip6.fr, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 0/1] Replace DEFINE_PCI_DEVICE_TABLE macro use
Date: Fri, 8 Aug 2014 15:56:02 +0200 [thread overview]
Message-ID: <1407506163-8371-1-git-send-email-benoit.taine@lip6.fr> (raw)
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):
// <smpl>
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@
- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;
// </smpl>
I previously sent parts of this patch to check wether or not it was
worth sending, and Bjorn answered:
> Benoit, how about if you wait until about half-way through the merge
> window after v3.16 releases, generate an up-to-date single patch, and
> post that? Then we can try to get it in before v3.17-rc1 to minimize
> merge hassles.
So here it is, based on linux-next on 2014-08-07.
next reply other threads:[~2014-08-08 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 13:56 Benoit Taine [this message]
2014-08-08 13:56 ` [PATCH 1/1] " Benoit Taine
2014-08-12 18:44 ` [PATCH 0/1] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407506163-8371-1-git-send-email-benoit.taine@lip6.fr \
--to=benoit.taine@lip6.fr \
--cc=bhelgaas@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®