From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbaHIXSe (ORCPT ); Sat, 9 Aug 2014 19:18:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3550 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751402AbaHIXSd (ORCPT ); Sat, 9 Aug 2014 19:18:33 -0400 Message-ID: <1407626290.9800.3.camel@ul30vt.home> Subject: Re: [PATCH] vfio: Fix build failure seen if vfio is built as module and EEH is enabled From: Alex Williamson To: Guenter Roeck Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Gavin Shan , Benjamin Herrenschmidt Date: Sat, 09 Aug 2014 17:18:10 -0600 In-Reply-To: <53E6A078.6040907@roeck-us.net> References: <1407603887-1419-1-git-send-email-linux@roeck-us.net> <1407612480.9800.1.camel@ul30vt.home> <53E6A078.6040907@roeck-us.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2014-08-09 at 15:28 -0700, Guenter Roeck wrote: > On 08/09/2014 12:28 PM, Alex Williamson wrote: > > On Sat, 2014-08-09 at 10:04 -0700, Guenter Roeck wrote: > >> The following build failure is seen with ppc:allmodconfig. > >> > >> ERROR: ".vfio_spapr_iommu_eeh_ioctl" [drivers/vfio/vfio_iommu_spapr_tce.ko] undefined! > >> ERROR: ".vfio_spapr_pci_eeh_open" [drivers/vfio/pci/vfio-pci.ko] undefined! > >> ERROR: ".vfio_spapr_pci_eeh_release" [drivers/vfio/pci/vfio-pci.ko] undefined! > >> > >> Simply exporting the missing symbols is insufficient, since drivers/vfio > >> can be built as module but drivers/vfio/vfio_spapr_eeh.c depends on > >> EEH which is boolean. The combination of obj-m for drivers/vfio and obj-y > >> for drivers/vfio/vfio_spapr_eeh.o results in the symbols being missed even > >> if exported. > >> > >> Export missing symbols and introduce new tristate configuration option > >> VFIO_EEH depending on both EEH and VFIO to fix the problem. > >> > >> Cc: Gavin Shan > >> Cc: Benjamin Herrenschmidt > >> Signed-off-by: Guenter Roeck > > > > Please try: > > > > git://github.com/awilliam/linux-vfio.git next > > > > This will be part of the next linux-next build, should resolve the > > problem, and I plan to ask for a pull early this coming week. Thanks, > > > > That should do for the most part, but it will select VFIO_SPAPR_EEH > even if EEH is not configured. You would need something like > select VFIO_SPAPR_EEH if (PPC_POWERNV || PPC_PSERIES) && EEH > to prevent that. Feel free to post a patch against this branch. Thanks, Alex