From: Joe Perches <joe@perches.com>
To: Suman Kumar <suman@inforcecomputing.com>
Cc: hverkuil@xs4all.nl, g.liakhovetski@gmx.de, m.chehab@samsung.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: soc_camera.c: fixed coding style: lines over 80 char
Date: Sun, 10 Aug 2014 14:00:49 -0700 [thread overview]
Message-ID: <1407704449.4082.11.camel@joe-AO725> (raw)
In-Reply-To: <1407703301-2037-1-git-send-email-suman@inforcecomputing.com>
On Mon, 2014-08-11 at 02:11 +0530, Suman Kumar wrote:
> Fixes a coding style issue of 'lines over 80 char' reported by
> checkpatch.pl
[]
> diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c
[]
> @@ -1430,7 +1434,7 @@ static int soc_camera_async_bound(struct v4l2_async_notifier *notifier,
> struct v4l2_async_subdev *asd)
> {
> struct soc_camera_async_client *sasc = container_of(notifier,
> - struct soc_camera_async_client, notifier);
> + struct soc_camera_async_client, notifier);
> struct soc_camera_device *icd = platform_get_drvdata(sasc->pdev);
I don't easily parse the original or modified lines.
If you are really concerned abut 80 columns and readability
instead of merely quieting checkpatch, these might be better
on multiple lines like
struct soc_camera_async_client *sasc;
struct soc_camera_device *icd;
sasc = container_of(notifier, struct soc_camera_async_client, notifier);
icd = platform_get_drvdata(sasc->pdev);
prev parent reply other threads:[~2014-08-10 21:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 20:41 Suman Kumar
2014-08-10 21:00 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407704449.4082.11.camel@joe-AO725 \
--to=joe@perches.com \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=suman@inforcecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®