From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754020AbaHKOuy (ORCPT ); Mon, 11 Aug 2014 10:50:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55283 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753959AbaHKOuL (ORCPT ); Mon, 11 Aug 2014 10:50:11 -0400 From: Don Zickus To: akpm@linux-foundation.org Cc: kvm@vger.kernel.org, pbonzini@redhat.com, mingo@redhat.com, LKML , Ulrich Obergfell , Andrew Jones , Don Zickus Subject: [PATCH 5/5] kvm: ensure hard lockup detection is disabled by default Date: Mon, 11 Aug 2014 10:49:27 -0400 Message-Id: <1407768567-171794-6-git-send-email-dzickus@redhat.com> In-Reply-To: <1407768567-171794-1-git-send-email-dzickus@redhat.com> References: <1407768567-171794-1-git-send-email-dzickus@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ulrich Obergfell Use watchdog_enable_hardlockup_detector() to set hard lockup detection's default value to false. It's risky to run this detection in a guest, as false positives are easy to trigger, especially if the host is overcommitted. Signed-off-by: Ulrich Obergfell Signed-off-by: Andrew Jones Signed-off-by: Don Zickus --- arch/x86/kernel/kvm.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 3dd8e2c..95c3cb1 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include #include @@ -499,6 +500,13 @@ void __init kvm_guest_init(void) #else kvm_guest_cpu_init(); #endif + + /* + * Hard lockup detection is enabled by default. Disable it, as guests + * can get false positives too easily, for example if the host is + * overcommitted. + */ + watchdog_enable_hardlockup_detector(false); } static noinline uint32_t __kvm_cpuid_base(void) -- 1.7.1