From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752771AbaHLGwn (ORCPT ); Tue, 12 Aug 2014 02:52:43 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:64785 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbaHLGwm (ORCPT ); Tue, 12 Aug 2014 02:52:42 -0400 From: Sanjeev Sharma To: , CC: , , , , Sanjeev Sharma , Sanjeev Sharma Subject: [PATCH] zd1211rw: replace ZD_ASSERT with lockdep_assert_held() Date: Tue, 12 Aug 2014 12:35:33 +0530 Message-ID: <1407827133-29493-1-git-send-email-sanjeev_sharma@mentor.com> X-Mailer: git-send-email 1.7.11.7 MIME-Version: 1.0 Content-Type: text/plain X-OriginalArrivalTime: 12 Aug 2014 06:52:39.0162 (UTC) FILETIME=[01AD4DA0:01CFB5FA] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on some architecture spin_is_locked() always return false in uniprocessor configuration and therefore it would be advise to replace with lockdep_assert_held(). Signed-off-by: Sanjeev Sharma --- drivers/net/wireless/zd1211rw/zd_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c index e7af261..72c0bc2 100644 --- a/drivers/net/wireless/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zd1211rw/zd_mac.c @@ -235,7 +235,7 @@ void zd_mac_clear(struct zd_mac *mac) { flush_workqueue(zd_workqueue); zd_chip_clear(&mac->chip); - ZD_ASSERT(!spin_is_locked(&mac->lock)); + lockdep_assert_held(!spin_is_locked(&mac->lock)); ZD_MEMCLEAR(mac, sizeof(struct zd_mac)); } -- 1.7.11.7