mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chris Ball <chris@printf.net>, Anton Vorontsov <anton@enomsg.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, Pawel Moll <pawel.moll@arm.com>
Subject: [PATCH 3/5 v2] mmc: sdhci-pltfm: Do not use parent as the host's device
Date: Tue, 12 Aug 2014 11:37:52 +0100	[thread overview]
Message-ID: <1407839872-12864-1-git-send-email-pawel.moll@arm.com> (raw)
In-Reply-To: <CAPDyKFrb9OSbhHtn=wgbs9Yky1t453rdNBJVgGA62vER-65dYw@mail.gmail.com>

The code selecting a device for the sdhci host has been
continuously tweaked (4b711cb13843f5082e82970dd1e8031383134a65
"mmc: sdhci-pltfm: Add structure for host-specific data" and
a4d2177f00a5252d825236c5124bc1e9918bdb41 "mmc: sdhci-pltfm: dt
device does not pass parent to sdhci_alloc_host" while there
does not seem to be any reason to use platform device's parent
in the first place.

The comment saying "Some PCI-based MFD need the parent here"
seem to refer to Timberdale FPGA driver (the only MFD driver
registering SDHCI cell, drivers/mfd/timberdale.c) but again,
the only situation when parent device matter is runtime PM,
which is not implemented for Timberdale.

Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---
 drivers/mmc/host/sdhci-pltfm.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index 7e834fb..c5b01d6 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -123,7 +123,6 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
 				    size_t priv_size)
 {
 	struct sdhci_host *host;
-	struct device_node *np = pdev->dev.of_node;
 	struct resource *iomem;
 	int ret;
 
@@ -136,13 +135,8 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
 	if (resource_size(iomem) < 0x100)
 		dev_err(&pdev->dev, "Invalid iomem size!\n");
 
-	/* Some PCI-based MFD need the parent here */
-	if (pdev->dev.parent != &platform_bus && !np)
-		host = sdhci_alloc_host(pdev->dev.parent,
-			sizeof(struct sdhci_pltfm_host) + priv_size);
-	else
-		host = sdhci_alloc_host(&pdev->dev,
-			sizeof(struct sdhci_pltfm_host) + priv_size);
+	host = sdhci_alloc_host(&pdev->dev,
+		sizeof(struct sdhci_pltfm_host) + priv_size);
 
 	if (IS_ERR(host)) {
 		ret = PTR_ERR(host);
-- 
1.9.1


  reply	other threads:[~2014-08-12 10:38 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 14:23 [PATCH 1/5] ARM: imx: Remove references to platform_bus in mxc code Pawel Moll
2014-07-25 14:23 ` [PATCH 2/5] char: tile-srom: Remove reference to platform_bus Pawel Moll
2014-07-31 20:24   ` Chris Metcalf
2014-07-31 21:32     ` Greg Kroah-Hartman
2014-08-01 17:21     ` Pawel Moll
2014-08-05 20:08       ` Chris Metcalf
2014-08-05 23:06         ` Greg Kroah-Hartman
2014-08-08 16:34         ` Pawel Moll
2014-08-08 16:39           ` Pawel Moll
2014-08-11  2:38           ` Chris Metcalf
2014-08-29 18:43           ` Chris Metcalf
2014-09-01 12:27             ` Pawel Moll
2014-09-01 13:53               ` Chris Metcalf
2014-07-25 14:23 ` [PATCH 3/5] mmc: sdhci-pltfm: Do not use parent as the host's device Pawel Moll
2014-08-08 16:36   ` Pawel Moll
2014-08-11  9:07     ` Ulf Hansson
2014-08-11  9:15       ` Pawel Moll
2014-08-11  9:32         ` Ulf Hansson
2014-08-12  8:58           ` Ulf Hansson
2014-08-12 10:37             ` Pawel Moll [this message]
2014-08-12 11:51               ` [PATCH 3/5 v2] " Ulf Hansson
2014-08-11 10:02         ` [PATCH 3/5] " Russell King - ARM Linux
2014-07-25 14:23 ` [PATCH 4/5] [SCSI] Do not use platform_bus as a parent Pawel Moll
2014-07-25 14:46   ` James Bottomley
2014-07-25 15:40     ` Pawel Moll
2014-07-26 20:11     ` Greg Kroah-Hartman
2014-07-27  3:52       ` James Bottomley
2014-07-27 15:07         ` Greg Kroah-Hartman
2014-08-01 17:25           ` Pawel Moll
2014-07-25 14:23 ` [PATCH 5/5] platform: Make platform_bus device a platform device Pawel Moll
2014-07-26 20:12   ` Greg Kroah-Hartman
2014-08-01 17:21     ` Pawel Moll
2014-07-26 20:13   ` Greg Kroah-Hartman
2014-08-01 17:21     ` Pawel Moll
2014-07-28  1:45 ` [PATCH 1/5] ARM: imx: Remove references to platform_bus in mxc code Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407839872-12864-1-git-send-email-pawel.moll@arm.com \
    --to=pawel.moll@arm.com \
    --cc=anton@enomsg.org \
    --cc=chris@printf.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®