From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: gregkh@linuxfoundation.org, swetland@google.com,
ccross@android.com, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, Phong Tran <tranmanphong@gmail.com>
Subject: [RFC PATCH] checkpatch: Warn on patch subjects with "checkpatch"
Date: Tue, 12 Aug 2014 09:37:01 -0700 [thread overview]
Message-ID: <1407861421.3141.21.camel@joe-AO725> (raw)
In-Reply-To: <1407860250-9779-2-git-send-email-tranmanphong@gmail.com>
I think patch subject lines with "checkpatch" in
them are almost never really useful.
Maybe a new checkpatch test to see if a subject line
is perhaps less than informational should be added.
Something like:
---
scripts/checkpatch.pl | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 31a731e..a690515 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2048,6 +2048,13 @@ sub process {
$in_commit_log = 0;
}
+# Check patch subject lines for "checkpatch" (but not checkpatch:)
+ if ($in_header_lines &&
+ $line =~ /^\s*subject:.*\bcheckpatch(?!(?:\.pl)?:)\b/i) {
+ WARN("BAD_PATCH_SUBJECT",
+ "Patch subjects with 'checkpatch' are not generally useful. Describe the change, not the tool that suggests the change.\n" . $herecurr);
+ }
+
# Check signature styles
if (!$in_header_lines &&
$line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
next prev parent reply other threads:[~2014-08-12 16:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 16:17 staging: android: ion checkpatch.pl cleanups Phong Tran
2014-08-12 16:17 ` [PATCH 1/5] staging: android: ion: ion.c Fix checkpatch warning Phong Tran
2014-08-12 16:37 ` Joe Perches [this message]
2014-08-13 10:37 ` [RFC PATCH] checkpatch: Warn on patch subjects with "checkpatch" Dan Carpenter
2014-08-12 16:17 ` [PATCH 2/5] staging: android: ion: ion_chunk_heap.c Fix checkpatch warning Phong Tran
2014-08-12 16:17 ` [PATCH 3/5] staging: android: ion: ion_system_heap.c " Phong Tran
2014-08-13 10:38 ` Dan Carpenter
2014-08-12 16:17 ` [PATCH 4/5] staging: android: ion: ion_carveout_heap.c " Phong Tran
2014-08-12 16:17 ` [PATCH 5/5] staging: android: ion: ion_dummy_driver.c " Phong Tran
2014-08-13 13:09 ` [Patch V2 1/3] staging: android: ion: ion_dummy_driver.c Fix coding style Phong Tran
2014-08-13 13:09 ` [Patch V2 2/3] staging: android: ion: ion.c " Phong Tran
2014-08-13 13:09 ` [Patch V2 3/3] staging: android: ion: " Phong Tran
2014-08-13 13:15 ` [Patch V2 1/3] staging: android: ion: ion_dummy_driver.c " Dan Carpenter
2014-08-13 13:37 ` [PATCH V3 1/3] staging: android: ion: ion_dummy_driver.c Replace kzalloc() by kcalloc() Phong Tran
2014-08-13 13:37 ` [PATCH V3 2/3] staging: android: ion: ion.c Add a new blank line after decleration Phong Tran
2014-08-13 13:37 ` [PATCH V3 3/3] staging: android: ion: Remove redundant return of void function Phong Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407861421.3141.21.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®