From: Antonios Motakis <a.motakis@virtualopensystems.com>
To: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu,
iommu@lists.linux-foundation.org
Cc: tech@virtualopensystems.com, a.rigo@virtualopensystems.com,
kvm@vger.kernel.org, christoffer.dall@linaro.org,
will.deacon@arm.com, kim.phillips@freescale.com,
stuart.yoder@freescale.com, eric.auger@linaro.org,
marc.zyngier@arm.com,
Antonios Motakis <a.motakis@virtualopensystems.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 4/4] VFIO: PLATFORM: DEVTREE: Return arrays of u32, u16, or u8
Date: Wed, 13 Aug 2014 13:02:19 +0200 [thread overview]
Message-ID: <1407927740-14993-5-git-send-email-a.motakis@virtualopensystems.com> (raw)
In-Reply-To: <1407927740-14993-1-git-send-email-a.motakis@virtualopensystems.com>
Certain properties of a device tree node are accessible as an array
of unsigned integers, either u32, u16, or u8. Let the VFIO user query
this type of device node properties.
Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
---
drivers/vfio/platform/devtree.c | 99 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
diff --git a/drivers/vfio/platform/devtree.c b/drivers/vfio/platform/devtree.c
index 80c60d4..331cc34 100644
--- a/drivers/vfio/platform/devtree.c
+++ b/drivers/vfio/platform/devtree.c
@@ -98,6 +98,96 @@ static int devtree_get_full_name(struct device_node *np, void __user *datap,
return 0;
}
+static int devtree_get_u32_arr(const struct device_node *np, const char *name,
+ void __user *datap, unsigned long datasz)
+{
+ int ret;
+ int n;
+ u32 *out;
+
+ n = of_property_count_elems_of_size(np, name, sizeof(u32));
+ if (n < 0)
+ return n;
+
+ if (n * sizeof(u32) > datasz)
+ return -EAGAIN;
+
+ out = kcalloc(n, sizeof(u32), GFP_KERNEL);
+ if (!out)
+ return -EFAULT;
+
+ ret = of_property_read_u32_array(np, name, out, n);
+ if (ret)
+ goto out;
+
+ if (copy_to_user(datap, out, n * sizeof(u32)))
+ ret = -EFAULT;
+
+out:
+ kfree(out);
+ return ret;
+}
+
+static int devtree_get_u16_arr(const struct device_node *np, const char *name,
+ void __user *datap, unsigned long datasz)
+{
+ int ret;
+ int n;
+ u16 *out;
+
+ n = of_property_count_elems_of_size(np, name, sizeof(u16));
+ if (n < 0)
+ return n;
+
+ if (n * sizeof(u16) > datasz)
+ return -EAGAIN;
+
+ out = kcalloc(n, sizeof(u16), GFP_KERNEL);
+ if (!out)
+ return -EFAULT;
+
+ ret = of_property_read_u16_array(np, name, out, n);
+ if (ret)
+ goto out;
+
+ if (copy_to_user(datap, out, n * sizeof(u16)))
+ ret = -EFAULT;
+
+out:
+ kfree(out);
+ return ret;
+}
+
+static int devtree_get_u8_arr(const struct device_node *np, const char *name,
+ void __user *datap, unsigned long datasz)
+{
+ int ret;
+ int n;
+ u8 *out;
+
+ n = of_property_count_elems_of_size(np, name, sizeof(u8));
+ if (n < 0)
+ return n;
+
+ if (n * sizeof(u8) > datasz)
+ return -EAGAIN;
+
+ out = kcalloc(n, sizeof(u8), GFP_KERNEL);
+ if (!out)
+ return -EFAULT;
+
+ ret = of_property_read_u8_array(np, name, out, n);
+ if (ret)
+ goto out;
+
+ if (copy_to_user(datap, out, n * sizeof(u8)))
+ ret = -EFAULT;
+
+out:
+ kfree(out);
+ return ret;
+}
+
long vfio_platform_devtree_ioctl(struct vfio_platform_device *vdev,
unsigned long arg)
{
@@ -143,6 +233,15 @@ long vfio_platform_devtree_ioctl(struct vfio_platform_device *vdev,
} else if (info.type == VFIO_DEVTREE_ARR_TYPE_STRING)
ret = devtree_get_strings(vdev->of_node, name, datap, datasz);
+ else if (info.type == VFIO_DEVTREE_ARR_TYPE_U32)
+ ret = devtree_get_u32_arr(vdev->of_node, name, datap, datasz);
+
+ else if (info.type == VFIO_DEVTREE_ARR_TYPE_U16)
+ ret = devtree_get_u16_arr(vdev->of_node, name, datap, datasz);
+
+ else if (info.type == VFIO_DEVTREE_ARR_TYPE_U8)
+ ret = devtree_get_u8_arr(vdev->of_node, name, datap, datasz);
+
kfree(name);
out:
--
1.8.3.2
prev parent reply other threads:[~2014-08-13 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1407927740-14993-1-git-send-email-a.motakis@virtualopensystems.com>
2014-08-13 11:02 ` [PATCH 1/4] VFIO: PLATFORM: Add device tree info API and skeleton Antonios Motakis
2014-08-13 11:02 ` [PATCH 2/4] VFIO: PLATFORM: DEVTREE: Return available property names Antonios Motakis
2014-08-13 11:02 ` [PATCH 3/4] VFIO: PLATFORM: DEVTREE: Access property as a list of strings Antonios Motakis
2014-08-13 11:02 ` Antonios Motakis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407927740-14993-5-git-send-email-a.motakis@virtualopensystems.com \
--to=a.motakis@virtualopensystems.com \
--cc=a.rigo@virtualopensystems.com \
--cc=alex.williamson@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kim.phillips@freescale.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=stuart.yoder@freescale.com \
--cc=tech@virtualopensystems.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome