From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbaHPQt6 (ORCPT ); Sat, 16 Aug 2014 12:49:58 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:32922 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbaHPQt4 (ORCPT ); Sat, 16 Aug 2014 12:49:56 -0400 From: Colin King To: Artem Bityutskiy , David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] UBI: block: fix dereference on uninitialized dev Date: Sat, 16 Aug 2014 17:49:53 +0100 Message-Id: <1408207793-11536-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 2.1.0.rc1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King commit 4df38926f337 ("UBI: block: Avoid disk size integer overflow") introduced a dereference on dev (which is not initialized at that point) when printing a warning message. Remove the reference to the dev's disk_name. Found by cppcheck: [drivers/mtd/ubi/block.c:509]: (error) Uninitialized variable: dev Signed-off-by: Colin Ian King --- drivers/mtd/ubi/block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c index 33c6495..944bdbd 100644 --- a/drivers/mtd/ubi/block.c +++ b/drivers/mtd/ubi/block.c @@ -505,8 +505,8 @@ static int ubiblock_resize(struct ubi_volume_info *vi) u64 disk_capacity = ((u64)vi->size * vi->usable_leb_size) >> 9; if ((sector_t)disk_capacity != disk_capacity) { - ubi_warn("%s: the volume is too big, cannot resize (%d LEBs)", - dev->gd->disk_name, vi->size); + ubi_warn("block: the volume is too big, cannot resize (%d LEBs)", + vi->size); return -EFBIG; } /* -- 2.1.0.rc1