From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Tair Rzayev <tair.rzayev@gmail.com>,
arve@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: binder.c: rename binder_user_error()
Date: Sat, 16 Aug 2014 13:13:21 -0700 [thread overview]
Message-ID: <1408220001.2683.103.camel@joe-AO725> (raw)
In-Reply-To: <20140815064532.GA20920@kroah.com>
On Fri, 2014-08-15 at 14:45 +0800, Greg KH wrote:
> On Sun, Aug 10, 2014 at 10:42:53PM +0300, Tair Rzayev wrote:
> > Rename binder_user_error() to shorter but no less readable binder_usr_err()
> > which fixes 34 "line over 80 characters" checkpatch warnings
>
> Those are false-positives due to the fact that we should not wrap
> strings and checkpatch doesn't understand this custom macro.
>
> So don't worry about it, the code is fine as-is.
Using <foo>_err instead of <foo>_error means that
checkpatch can successfully ignore long lines of
the format portion of this macro.
prev parent reply other threads:[~2014-08-16 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 19:42 Tair Rzayev
2014-08-15 6:45 ` Greg KH
2014-08-16 20:13 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408220001.2683.103.camel@joe-AO725 \
--to=joe@perches.com \
--cc=arve@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tair.rzayev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®