From: Kever Yang <kever.yang@rock-chips.com>
To: Russell King <linux@arm.linux.org.uk>
Cc: Will Deacon <will.deacon@arm.com>,
Shawn Guo <shawn.guo@linaro.org>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Nicolas Pitre <nico@linaro.org>,
Marc Carino <marc.ceeeee@gmail.com>,
Mahesh Sivasubramanian <msivasub@codeaurora.org>,
Jonathan Austin <Jonathan.Austin@arm.com>,
heiko@sntech.de, addy.ke@rock-chips.com, xjq@rock-chips.com,
cf@rock-chips.com, hj@rock-chips.com, huangtao@rock-chips.com,
Ben Dooks <ben.dooks@codethink.co.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Kever Yang <kever.yang@rock-chips.com>
Subject: [PATCH] ARM: errata: Workaround for Cortex-A12 erratum 818325
Date: Mon, 18 Aug 2014 17:58:09 +0800 [thread overview]
Message-ID: <1408355889-4176-1-git-send-email-kever.yang@rock-chips.com> (raw)
From: Huang Tao <huangtao@rock-chips.com>
On Cortex-A12 (r0p0..r0p1-00lac0-rc11), when a CPU executes a sequence of
two conditional store instructions with opposite condition code and
updating the same register, the system might enter a deadlock if the
second conditional instruction is an UNPREDICTABLE STR or STM
instruction. This workaround setting bit[12] of the Feature Register
prevents the erratum. This bit disables an optimisation applied to a
sequence of 2 instructions that use opposing condition codes.
Signed-off-by: Huang Tao <huangtao@rock-chips.com>
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
arch/arm/Kconfig | 13 +++++++++++++
arch/arm/mm/proc-v7.S | 15 ++++++++++++++-
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 32cbbd5..4545835 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1245,6 +1245,19 @@ config ARM_ERRATA_773022
loop buffer may deliver incorrect instructions. This
workaround disables the loop buffer to avoid the erratum.
+config ARM_ERRATA_818325
+ bool "ARM errata: Execution of an UNPREDICTABLE STR or STM instruction might deadlock"
+ depends on CPU_V7
+ help
+ This option enables the workaround for the 818325 Cortex-A12
+ (r0p0..r0p1-00lac0-rc11) erratum. When a CPU executes a sequence of
+ two conditional store instructions with opposite condition code and
+ updating the same register, the system might enter a deadlock if the
+ second conditional instruction is an UNPREDICTABLE STR or STM
+ instruction. This workaround setting bit[12] of the Feature Register
+ prevents the erratum. This bit disables an optimisation applied to a
+ sequence of 2 instructions that use opposing condition codes.
+
endmenu
source "arch/arm/common/Kconfig"
diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
index b5d67db..5ffdf97 100644
--- a/arch/arm/mm/proc-v7.S
+++ b/arch/arm/mm/proc-v7.S
@@ -408,7 +408,20 @@ __v7_setup:
mcrle p15, 0, r10, c1, c0, 1 @ write aux control register
#endif
-4: mov r10, #0
+ /* Cortex-A12 Errata */
+4: ldr r10, =0x00000c0d @ Cortex-A12 primary part number
+ teq r0, r10
+ bne 5f
+#ifdef CONFIG_ARM_ERRATA_818325
+ teq r6, #0x00 @ present in r0p0
+ teqne r6, #0x01 @ present in r0p1-00lac0-rc11
+ mrceq p15, 0, r10, c15, c0, 1 @ read diagnostic register
+ orreq r10, r10, #1 << 12 @ set bit #12
+ mcreq p15, 0, r10, c15, c0, 1 @ write diagnostic register
+ isb
+#endif
+
+5: mov r10, #0
mcr p15, 0, r10, c7, c5, 0 @ I+BTB cache invalidate
#ifdef CONFIG_MMU
mcr p15, 0, r10, c8, c7, 0 @ invalidate I + D TLBs
--
1.8.3.2
next reply other threads:[~2014-08-18 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 9:58 Kever Yang [this message]
2014-08-26 8:49 ` Kever Yang
2014-08-26 10:14 ` Will Deacon
2014-08-26 11:36 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408355889-4176-1-git-send-email-kever.yang@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=Jonathan.Austin@arm.com \
--cc=addy.ke@rock-chips.com \
--cc=ben.dooks@codethink.co.uk \
--cc=cf@rock-chips.com \
--cc=gregory.clement@free-electrons.com \
--cc=heiko@sntech.de \
--cc=hj@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.ceeeee@gmail.com \
--cc=msivasub@codeaurora.org \
--cc=nico@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=will.deacon@arm.com \
--cc=xjq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®