From: Randy Dunlap <rdunlap@infradead.org>
To: Li zeming <zeming@nfschina.com>,
mcgrof@kernel.org, linux@rasmusvillemoes.dk, mbenes@suse.cz,
rafael@kernel.org, linux@weissschuh.net,
gregkh@linuxfoundation.org, christophe.jaillet@wanadoo.fr
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: params: Remove unnecessary ‘0’ values from err
Date: Sun, 9 Jul 2023 20:33:28 -0700 [thread overview]
Message-ID: <1408364e-6b73-7b50-e61c-470f3548a3a7@infradead.org> (raw)
In-Reply-To: <20230711194331.4361-1-zeming@nfschina.com>
On 7/11/23 12:43, Li zeming wrote:
> err is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> kernel/params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/params.c b/kernel/params.c
> index 6a7548979aa9..f8837a5f2c3e 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -331,7 +331,7 @@ EXPORT_SYMBOL(param_ops_bool);
>
> int param_set_bool_enable_only(const char *val, const struct kernel_param *kp)
> {
> - int err = 0;
> + int err;
> bool new_value;
> bool orig_value = *(bool *)kp->arg;
> struct kernel_param dummy_kp = *kp;
--
~Randy
next prev parent reply other threads:[~2023-07-10 3:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 19:43 Li zeming
2023-07-10 3:33 ` Randy Dunlap [this message]
2023-07-10 19:47 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408364e-6b73-7b50-e61c-470f3548a3a7@infradead.org \
--to=rdunlap@infradead.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@weissschuh.net \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®