mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Honggang Li <enjoymindful@gmail.com>
To: benjamin.romer@unisys.com, david.kershner@unisys.com,
	gregkh@linuxfoundation.org, erik.arfvidson@unisys.com,
	sparmaintainer@unisys.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Honggang Li <enjoymindful@gmail.com>
Subject: [linux-next PATCH] print u64 with %llu
Date: Tue, 19 Aug 2014 19:29:41 +0800	[thread overview]
Message-ID: <1408447783-22287-1-git-send-email-enjoymindful@gmail.com> (raw)

There are printk format issue and coding style issue for the lines
changed by this patch. This patch only fix the format issue. Please
take those coding style errors as false positives for this patch.

[real@name linux-next]$ scripts/checkpatch.pl outgoing2/0001-staging-unisys-virthba-virthba.c-print-u64-with-llu.patch 
WARNING: line over 80 characters
#45: FILE: drivers/staging/unisys/virthba/virthba.c:520:
+    LOGINF("scsihost->max_channel=%u, max_id=%u, max_lun=%llu, cmd_per_lun=%u, max_sectors=%hu, sg_tablesize=%hu\n",

WARNING: line over 80 characters
#63: FILE: drivers/staging/unisys/virthba/virthba.c:1142:
+		LOGERR("SCSICMD ****FAILED scsicmd:0x%p op:0x%x <%d:%d:%d:%llu> 0x%x-0x%x-0x%x-0x%x-0x%x.\n",

WARNING: line over 80 characters
#72: FILE: drivers/staging/unisys/virthba/virthba.c:1151:
+			LOGERR("Throtling SCSICMD errors disk <%d:%d:%d:%llu>\n",

total: 0 errors, 3 warnings, 32 lines checked

outgoing2/0001-staging-unisys-virthba-virthba.c-print-u64-with-llu.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[real@name linux-next]$ 

Honggang Li (1):
  staging: unisys/virthba/virthba.c print u64 with %llu

 drivers/staging/unisys/virthba/virthba.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2014-08-19 11:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19 11:29 Honggang Li [this message]
2014-08-19 11:29 ` Honggang Li
2014-08-19 11:29 ` [linux-next PATCH] staging: unisys/virthba/virthba.c " Honggang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408447783-22287-1-git-send-email-enjoymindful@gmail.com \
    --to=enjoymindful@gmail.com \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=erik.arfvidson@unisys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®