From: Philipp Zabel <p.zabel@pengutronix.de>
To: Yannis Damigos <giannis.damigos@gmail.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
Fabio Estevam <fabio.estevam@freescale.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.
Date: Tue, 19 Aug 2014 16:05:39 +0200 [thread overview]
Message-ID: <1408457139.2899.11.camel@paszta.hi.pengutronix.de> (raw)
In-Reply-To: <1408456797-19437-1-git-send-email-giannis.damigos@gmail.com>
Am Dienstag, den 19.08.2014, 16:59 +0300 schrieb Yannis Damigos:
> This is a patch to the ipuv3-crtc.c file that fixes up two "lines
> over 80 characters" warnings found by the checkpatch.pl tool.
>
> Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
> ---
> drivers/staging/imx-drm/ipuv3-crtc.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
> index 720868b..c4c6455 100644
> --- a/drivers/staging/imx-drm/ipuv3-crtc.c
> +++ b/drivers/staging/imx-drm/ipuv3-crtc.c
> @@ -201,9 +201,9 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
> return ret;
> }
>
> - return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb,
> - 0, 0, mode->hdisplay, mode->vdisplay,
> - x, y, mode->hdisplay, mode->vdisplay);
> + return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode,
> + crtc->primary->fb, 0, 0, mode->hdisplay, mode->vdisplay,
> + x, y, mode->hdisplay, mode->vdisplay);
> }
>
> static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
This doesn't improve readability, though. Can we keep the alignment of
the x/y/width/height parameters?
> @@ -227,7 +227,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
>
> if (ipu_crtc->newfb) {
> ipu_crtc->newfb = NULL;
> - ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb,
> + ipu_plane_set_base(ipu_crtc->plane[0],
> + ipu_crtc->base.primary->fb,
> ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y);
> ipu_crtc_handle_pageflip(ipu_crtc);
> }
regards
Philipp
next prev parent reply other threads:[~2014-08-19 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 11:57 [PATCH 1/1] Fix some code style issues Yannis Damigos
2014-08-19 12:41 ` Greg Kroah-Hartman
2014-08-19 13:59 ` [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed Yannis Damigos
2014-08-19 14:05 ` Philipp Zabel [this message]
2014-08-19 14:36 ` Yannis Damigos
2014-08-19 14:36 ` [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed Yannis Damigos
2014-08-19 15:03 ` Russell King - ARM Linux
2014-08-19 15:26 ` Yannis Damigos
2014-08-19 15:42 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408457139.2899.11.camel@paszta.hi.pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.estevam@freescale.com \
--cc=giannis.damigos@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®